gdbots/query-parser-php

View on GitHub
src/Node/Node.php

Summary

Maintainability
A
1 hr
Test Coverage

The class Node has 13 public methods. Consider refactoring Node to keep number of public methods under 10.
Open

abstract class Node implements FromArray, ToArray, \JsonSerializable
{
    const NODE_TYPE = 'node';
    const COMPOUND_NODE = false;

Severity: Minor
Found in src/Node/Node.php by phpmd

Since: PHPMD 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'.

Source: http://phpmd.org/rules/codesize.txt

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
Severity: Minor
Found in src/Node/Node.php - About 45 mins to fix

    Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(
            $value,
            ?BoolOperator $boolOperator = null,
            bool $useBoost = false,
            float $boost = self::DEFAULT_BOOST,
    Severity: Minor
    Found in src/Node/Node.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __construct() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function __construct(
            $value,
            ?BoolOperator $boolOperator = null,
            bool $useBoost = false,
            float $boost = self::DEFAULT_BOOST,
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example:

    // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method __construct has a boolean flag argument $useBoost, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useBoost = false,
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method __construct has a boolean flag argument $useFuzzy, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useFuzzy = false,
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\Common\Util\StringUtils' in method 'factory'.
    Open

            $class = 'Gdbots\QueryParser\Node\\' . StringUtils::toCamelFromSnake($type);
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method '__construct'.
    Open

            $this->boolOperator = $boolOperator ?: BoolOperator::OPTIONAL();
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method '__construct'.
    Open

            $this->useBoost = $useBoost && static::SUPPORTS_BOOST && $this->boolOperator === BoolOperator::OPTIONAL();
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\Common\Util\NumberUtils' in method '__construct'.
    Open

                $this->fuzzy = NumberUtils::bound($fuzzy, static::MIN_FUZZY, static::MAX_FUZZY);
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'isRequired'.
    Open

            return $this->boolOperator->equals(BoolOperator::REQUIRED());
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'isProhibited'.
    Open

            return $this->boolOperator->equals(BoolOperator::PROHIBITED());
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'isOptional'.
    Open

            return $this->boolOperator->equals(BoolOperator::OPTIONAL());
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method '__construct'.
    Open

            $this->useFuzzy = $useFuzzy && static::SUPPORTS_FUZZY && $this->boolOperator === BoolOperator::OPTIONAL();
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid unused parameters such as '$builder'.
    Open

        public function acceptBuilder(QueryBuilder $builder): void
    Severity: Minor
    Found in src/Node/Node.php by phpmd

    Since: PHPMD 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example:

    class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

    Source: http://phpmd.org/rules/unusedcode.txt

    There are no issues that match your filters.

    Category
    Status