gdbots/query-parser-php

View on GitHub
src/Node/Subquery.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has a boolean flag argument $useBoost, which is a certain sign of a Single Responsibility Principle violation.
Open

        bool $useBoost = false,
Severity: Minor
Found in src/Node/Subquery.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'fromArray'.
Open

            $boolOperator = isset($data['bool_operator']) ? BoolOperator::create($data['bool_operator']) : null;
Severity: Minor
Found in src/Node/Subquery.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

There are no issues that match your filters.

Category
Status