gdbots/query-parser-php

View on GitHub
src/Node/Word.php

Summary

Maintainability
A
50 mins
Test Coverage

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $value,
        ?BoolOperator $boolOperator = null,
        bool $useBoost = false,
        float $boost = self::DEFAULT_BOOST,
        bool $useFuzzy = false,
Severity: Major
Found in src/Node/Word.php - About 50 mins to fix

    The method __construct has a boolean flag argument $useFuzzy, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useFuzzy = false,
    Severity: Minor
    Found in src/Node/Word.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method __construct has a boolean flag argument $trailingWildcard, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $trailingWildcard = false
    Severity: Minor
    Found in src/Node/Word.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method __construct has a boolean flag argument $useBoost, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $useBoost = false,
    Severity: Minor
    Found in src/Node/Word.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'fromArray'.
    Open

                $boolOperator = isset($data['bool_operator']) ? BoolOperator::create($data['bool_operator']) : null;
    Severity: Minor
    Found in src/Node/Word.php by phpmd

    Since: PHPMD 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example:

    class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    There are no issues that match your filters.

    Category
    Status