gdbots/query-parser-php

View on GitHub
src/QueryParser.php

Summary

Maintainability
F
3 days
Test Coverage

File QueryParser.php has 369 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\QueryParser;

Severity: Minor
Found in src/QueryParser.php - About 4 hrs to fix

    Function handleFieldWithRange has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
        {
            $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
            $matchTypes = true;
            $this->stream->next();
    Severity: Minor
    Found in src/QueryParser.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleFieldWithRange has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
        {
            $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
            $matchTypes = true;
            $this->stream->next();
    Severity: Major
    Found in src/QueryParser.php - About 2 hrs to fix

      Function handleSubquery has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          private function handleSubquery(BoolOperator $queryBoolOperator)
          {
              $this->stream->nextIf(Token::T_SUBQUERY_START);
              /** @var Node[] $nodes */
              $nodes = [];
      Severity: Minor
      Found in src/QueryParser.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleSubquery has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function handleSubquery(BoolOperator $queryBoolOperator)
          {
              $this->stream->nextIf(Token::T_SUBQUERY_START);
              /** @var Node[] $nodes */
              $nodes = [];
      Severity: Minor
      Found in src/QueryParser.php - About 1 hr to fix

        Function createNodes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private function createNodes(
                Token $token,
                BoolOperator $boolOperator,
                ?ComparisonOperator $comparisonOperator = null
            ): array {
        Severity: Minor
        Found in src/QueryParser.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createNodes has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function createNodes(
                Token $token,
                BoolOperator $boolOperator,
                ?ComparisonOperator $comparisonOperator = null
            ): array {
        Severity: Minor
        Found in src/QueryParser.php - About 1 hr to fix

          Method handleField has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function handleField(string $fieldName, BoolOperator $boolOperator)
              {
                  $lookahead = $this->stream->getLookahead();
                  if (!$lookahead instanceof Token) {
                      return $this->createWord($fieldName, $boolOperator);
          Severity: Minor
          Found in src/QueryParser.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return $this->createWord($fieldName, $boolOperator);
            Severity: Major
            Found in src/QueryParser.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $nodes;
              Severity: Major
              Found in src/QueryParser.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new Field($fieldName, $range, $boolOperator, $m['use_boost'], $m['boost']);
                Severity: Major
                Found in src/QueryParser.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return new Field($fieldName, $nodes[0], $boolOperator, $m['use_boost'], $m['boost']);
                  Severity: Major
                  Found in src/QueryParser.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return new Field($fieldName, $range, $boolOperator, $m['use_boost'], $m['boost']);
                    Severity: Major
                    Found in src/QueryParser.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return $this->createWord($fieldName, $boolOperator);
                      Severity: Major
                      Found in src/QueryParser.php - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                switch ($this->stream->getCurrent()->getType()) {
                                    case Token::T_NUMBER:
                                        $lowerNode = $this->createNumber($this->stream->getCurrent()->getValue());
                                        break;
                        
                        
                        Severity: Major
                        Found in src/QueryParser.php and 1 other location - About 2 hrs to fix
                        src/QueryParser.php on lines 213..230

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 134.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                switch ($this->stream->getCurrent()->getType()) {
                                    case Token::T_NUMBER:
                                        $upperNode = $this->createNumber($this->stream->getCurrent()->getValue());
                                        break;
                        
                        
                        Severity: Major
                        Found in src/QueryParser.php and 1 other location - About 2 hrs to fix
                        src/QueryParser.php on lines 191..208

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 134.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status