gdbots/query-parser-php

View on GitHub
src/QueryParser.php

Summary

Maintainability
F
3 days
Test Coverage

File QueryParser.php has 370 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

namespace Gdbots\QueryParser;

Severity: Minor
Found in src/QueryParser.php - About 4 hrs to fix

    Function handleFieldWithRange has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
        {
            $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
            $matchTypes = true;
            $this->stream->next();
    Severity: Minor
    Found in src/QueryParser.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class QueryParser has an overall complexity of 85 which is very high. The configured complexity threshold is 50.
    Open

    class QueryParser
    {
        /** @var Tokenizer */
        protected $tokenizer;
    
    
    Severity: Minor
    Found in src/QueryParser.php by phpmd

    Since: PHPMD 0.2.5

    The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

    Example:

    class Foo {
          public function bar() {
              if ($a == $b)  {
                  if ($a1 == $b1) {
                      fiddle();
                  } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                  }
              }
          }
          public function baz() {
              if ($a == $b) {
                  if ($a1 == $b1) {
                      fiddle();
                  } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                  }
              }
          }
          // Several other complex methods
      }

    Source: http://phpmd.org/rules/codesize.txt

    Method handleFieldWithRange has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
        {
            $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
            $matchTypes = true;
            $this->stream->next();
    Severity: Major
    Found in src/QueryParser.php - About 2 hrs to fix

      Function handleSubquery has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function handleSubquery(BoolOperator $queryBoolOperator)
          {
              $this->stream->nextIf(Token::T_SUBQUERY_START);
              /** @var Node[] $nodes */
              $nodes = [];
      Severity: Minor
      Found in src/QueryParser.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleSubquery has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleSubquery(BoolOperator $queryBoolOperator)
          {
              $this->stream->nextIf(Token::T_SUBQUERY_START);
              /** @var Node[] $nodes */
              $nodes = [];
      Severity: Minor
      Found in src/QueryParser.php - About 1 hr to fix

        Function createNodes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function createNodes(
                Token $token,
                BoolOperator $boolOperator,
                ?ComparisonOperator $comparisonOperator = null
            ): array {
        Severity: Minor
        Found in src/QueryParser.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createNodes has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function createNodes(
                Token $token,
                BoolOperator $boolOperator,
                ?ComparisonOperator $comparisonOperator = null
            ): array {
        Severity: Minor
        Found in src/QueryParser.php - About 1 hr to fix

          Method handleField has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function handleField(string $fieldName, BoolOperator $boolOperator)
              {
                  $lookahead = $this->stream->getLookahead();
                  if (!$lookahead instanceof Token) {
                      return $this->createWord($fieldName, $boolOperator);
          Severity: Minor
          Found in src/QueryParser.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return $this->createWord($fieldName, $boolOperator);
            Severity: Major
            Found in src/QueryParser.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $this->createWord($fieldName, $boolOperator);
              Severity: Major
              Found in src/QueryParser.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $nodes;
                Severity: Major
                Found in src/QueryParser.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new Field($fieldName, $range, $boolOperator, $m['use_boost'], $m['boost']);
                  Severity: Major
                  Found in src/QueryParser.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return new Field($fieldName, $nodes[0], $boolOperator, $m['use_boost'], $m['boost']);
                    Severity: Major
                    Found in src/QueryParser.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new Field($fieldName, $range, $boolOperator, $m['use_boost'], $m['boost']);
                      Severity: Major
                      Found in src/QueryParser.php - About 30 mins to fix

                        The method handleSubquery() has an NPath complexity of 390. The configured NPath complexity threshold is 200.
                        Open

                            protected function handleSubquery(BoolOperator $queryBoolOperator)
                            {
                                $this->stream->nextIf(Token::T_SUBQUERY_START);
                                /** @var Node[] $nodes */
                                $nodes = [];
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example:

                        class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                        Source: http://phpmd.org/rules/codesize.txt

                        The method handleFieldWithRange() has an NPath complexity of 2016. The configured NPath complexity threshold is 200.
                        Open

                            protected function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
                            {
                                $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
                                $matchTypes = true;
                                $this->stream->next();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example:

                        class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                        Source: http://phpmd.org/rules/codesize.txt

                        The method createNodes() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function createNodes(
                                Token $token,
                                BoolOperator $boolOperator,
                                ?ComparisonOperator $comparisonOperator = null
                            ): array {
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example:

                        // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/codesize.txt

                        The method handleFieldWithRange() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function handleFieldWithRange(string $fieldName, BoolOperator $boolOperator)
                            {
                                $exclusive = $this->stream->typeIs(Token::T_RANGE_EXCL_START);
                                $matchTypes = true;
                                $this->stream->next();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example:

                        // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/codesize.txt

                        The method handleSubquery() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function handleSubquery(BoolOperator $queryBoolOperator)
                            {
                                $this->stream->nextIf(Token::T_SUBQUERY_START);
                                /** @var Node[] $nodes */
                                $nodes = [];
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example:

                        // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/codesize.txt

                        The class QueryParser has a coupling between objects value of 23. Consider to reduce the number of dependencies under 13.
                        Open

                        class QueryParser
                        {
                            /** @var Tokenizer */
                            protected $tokenizer;
                        
                        
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.1.0

                        A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                        Example:

                        class Foo {
                              /**
                               * @var \foo\bar\X
                               */
                              private $x = null;
                        
                              /**
                               * @var \foo\bar\Y
                               */
                              private $y = null;
                        
                              /**
                               * @var \foo\bar\Z
                               */
                              private $z = null;
                        
                              public function setFoo(\Foo $foo) {}
                              public function setBar(\Bar $bar) {}
                              public function setBaz(\Baz $baz) {}
                        
                              /**
                               * @return \SplObjectStorage
                               * @throws \OutOfRangeException
                               * @throws \InvalidArgumentException
                               * @throws \ErrorException
                               */
                              public function process(\Iterator $it) {}
                        
                              // ...
                          }

                        Source: http://phpmd.org/rules/design.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'handleFieldWithRange'.
                        Open

                                        $upperNode = $this->createWord($this->stream->getCurrent()->getValue(), BoolOperator::OPTIONAL());
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'getBoolOperator'.
                        Open

                                    return BoolOperator::PROHIBITED();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'getBoolOperator'.
                        Open

                                    return BoolOperator::REQUIRED();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createEmoji'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'handleField'.
                        Open

                                $nodes = $this->createNodes($fieldValue, BoolOperator::OPTIONAL(), $comparisonOperator);
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createEmoji'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'getBoolOperator'.
                        Open

                                return BoolOperator::create($default);
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'handleFieldWithRange'.
                        Open

                                        $upperNode = $this->createDate($this->stream->getCurrent()->getValue(), BoolOperator::OPTIONAL());
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createEmoticon'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createHashtag'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createMention'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'handleFieldWithRange'.
                        Open

                                        $lowerNode = $this->createDate($this->stream->getCurrent()->getValue(), BoolOperator::OPTIONAL());
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createEmoticon'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createMention'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'handleFieldWithRange'.
                        Open

                                        $lowerNode = $this->createWord($this->stream->getCurrent()->getValue(), BoolOperator::OPTIONAL());
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\BoolOperator' in method 'createHashtag'.
                        Open

                                $boolOperator = $boolOperator->equals(BoolOperator::OPTIONAL()) ? BoolOperator::REQUIRED() : $boolOperator;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        The method getComparisonOperator uses an else expression. Else is never necessary and you can simplify the code to work without else.
                        Open

                                } else {
                                    return null;
                                }
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                        Example:

                        class Foo
                          {
                              public function bar($flag)
                              {
                                  if ($flag) {
                                      // one branch
                                  } else {
                                      // another branch
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Avoid using static access to class '\Gdbots\QueryParser\Enum\ComparisonOperator' in method 'getComparisonOperator'.
                        Open

                                return ComparisonOperator::create($op);
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 1.4.0

                        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                        Example:

                        class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                        Source: http://phpmd.org/rules/cleancode.txt

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                switch ($this->stream->getCurrent()->getType()) {
                                    case Token::T_NUMBER:
                                        $lowerNode = $this->createNumber($this->stream->getCurrent()->getValue());
                                        break;
                        
                        
                        Severity: Major
                        Found in src/QueryParser.php and 1 other location - About 3 hrs to fix
                        src/QueryParser.php on lines 224..241

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 126.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                switch ($this->stream->getCurrent()->getType()) {
                                    case Token::T_NUMBER:
                                        $upperNode = $this->createNumber($this->stream->getCurrent()->getValue());
                                        break;
                        
                        
                        Severity: Major
                        Found in src/QueryParser.php and 1 other location - About 3 hrs to fix
                        src/QueryParser.php on lines 202..219

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 126.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $op. Configured minimum length is 3.
                        Open

                                    $op = ComparisonOperator::GT;
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                    $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                    $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        Avoid variables with short names like $m. Configured minimum length is 3.
                        Open

                                $m = $this->getModifiers();
                        Severity: Minor
                        Found in src/QueryParser.php by phpmd

                        Since: PHPMD 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example:

                        class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                        Source: http://phpmd.org/rules/naming.txt

                        There are no issues that match your filters.

                        Category
                        Status