cozy/control/mpris.py

Summary

Maintainability
D
1 day
Test Coverage

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

        track_id = track_id + randint(10000000, 90000000)
Severity: Info
Found in cozy/control/mpris.py by bandit

File mpris.py has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Forked from https://github.com/gnumdk/lollypop/blob/master/lollypop/mpris.py
# copyright (c) 2014-2017 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
# copyright (c) 2016 Gaurav Narula
# copyright (c) 2016 Felipe Borges <felipeborges@gnome.org>
# copyright (c) 2013 Arnel A. Borja <kyoushuu@yahoo.com>
Severity: Minor
Found in cozy/control/mpris.py - About 4 hrs to fix

    MPRIS has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MPRIS(Server):
        """
        <!DOCTYPE node PUBLIC
        "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
        "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
    Severity: Minor
    Found in cozy/control/mpris.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method Get. (12)
      Open

          def Get(self, interface, property_name):
              if property_name in ["CanQuit", "CanRaise", "CanSeek",
                                   "CanControl", "HasRatingsExtension"]:
                  return GLib.Variant("b", True)
              elif property_name == "HasTrackList":
      Severity: Minor
      Found in cozy/control/mpris.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method on_method_call. (8)
      Open

          def on_method_call(self,
                             connection,
                             sender,
                             object_path,
                             interface_name,
      Severity: Minor
      Found in cozy/control/mpris.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in class Server. (7)
      Open

      class Server:
          def __init__(self, con, path):
              method_outargs = {}
              method_inargs = {}
              for interface in Gio.DBusNodeInfo.new_for_xml(self.__doc__).interfaces:
      Severity: Minor
      Found in cozy/control/mpris.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method GetAll. (6)
      Open

          def GetAll(self, interface):
              ret = {}
              if interface == self.__MPRIS_IFACE:
                  for property_name in ["CanQuit",
                                        "CanRaise",
      Severity: Minor
      Found in cozy/control/mpris.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method __init__. (6)
      Open

          def __init__(self, con, path):
              method_outargs = {}
              method_inargs = {}
              for interface in Gio.DBusNodeInfo.new_for_xml(self.__doc__).interfaces:
      
      
      Severity: Minor
      Found in cozy/control/mpris.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function Get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def Get(self, interface, property_name):
              if property_name in ["CanQuit", "CanRaise", "CanSeek",
                                   "CanControl", "HasRatingsExtension"]:
                  return GLib.Variant("b", True)
              elif property_name == "HasTrackList":
      Severity: Minor
      Found in cozy/control/mpris.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function on_method_call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def on_method_call(self,
                             connection,
                             sender,
                             object_path,
                             interface_name,
      Severity: Minor
      Found in cozy/control/mpris.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function on_method_call has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def on_method_call(self,
      Severity: Major
      Found in cozy/control/mpris.py - About 50 mins to fix

        Function GetAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def GetAll(self, interface):
                ret = {}
                if interface == self.__MPRIS_IFACE:
                    for property_name in ["CanQuit",
                                          "CanRaise",
        Severity: Minor
        Found in cozy/control/mpris.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    return None
        Severity: Major
        Found in cozy/control/mpris.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return GLib.Variant("as", ["file"])
          Severity: Major
          Found in cozy/control/mpris.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return GLib.Variant("s", self.__get_status())
            Severity: Major
            Found in cozy/control/mpris.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return GLib.Variant(
              Severity: Major
              Found in cozy/control/mpris.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                             return GLib.Variant("d", self._player.volume)
                Severity: Major
                Found in cozy/control/mpris.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return GLib.Variant("as", ["application/ogg",
                  Severity: Major
                  Found in cozy/control/mpris.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return GLib.Variant("a{sv}", self.__metadata)
                    Severity: Major
                    Found in cozy/control/mpris.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return GLib.Variant("b", self._player.loaded_book is not None)
                      Severity: Major
                      Found in cozy/control/mpris.py - About 30 mins to fix

                        There are no issues that match your filters.

                        Category
                        Status