Showing 178 of 178 total issues

File player.py has 512 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import threading
import time

import cozy.ext.inject as inject
from gi.repository import Gst, GLib
Severity: Major
Found in cozy/control/player.py - About 1 day to fix

    File main_view.py has 479 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import webbrowser
    
    import cozy.ext.inject as inject
    from cozy.application_settings import ApplicationSettings
    from cozy.architecture.event_sender import EventSender
    Severity: Minor
    Found in cozy/ui/main_view.py - About 7 hrs to fix

      File titlebar.py has 401 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import cozy.control.player as player
      import cozy.tools as tools
      import cozy.ui
      from cozy.application_settings import ApplicationSettings
      from cozy.control.artwork_cache import ArtworkCache
      Severity: Minor
      Found in cozy/ui/titlebar.py - About 5 hrs to fix

        CozyUI has 40 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class CozyUI(EventSender, metaclass=Singleton):
            """
            CozyUI is the main ui class.
            """
            # The book that is currently loaded in the player
        Severity: Minor
        Found in cozy/ui/main_view.py - About 5 hrs to fix

          File __init__.py has 370 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          """
          Python dependency injection framework.
          
          Usage:
          - Create an optional configuration::
          Severity: Minor
          Found in cozy/ext/inject/__init__.py - About 4 hrs to fix

            File mpris.py has 352 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # Forked from https://github.com/gnumdk/lollypop/blob/master/lollypop/mpris.py
            # copyright (c) 2014-2017 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
            # copyright (c) 2016 Gaurav Narula
            # copyright (c) 2016 Felipe Borges <felipeborges@gnome.org>
            # copyright (c) 2013 Arnel A. Borja <kyoushuu@yahoo.com>
            Severity: Minor
            Found in cozy/control/mpris.py - About 4 hrs to fix

              Titlebar has 34 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Titlebar:
                  """
                  This class contains all titlebar logic.
                  """
                  _application_settings: ApplicationSettings = inject.attr(ApplicationSettings)
              Severity: Minor
              Found in cozy/ui/titlebar.py - About 4 hrs to fix

                Book has 31 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Book(Observable, EventSender):
                    _chapters: List[Chapter] = None
                    _settings: Settings = inject.attr(Settings)
                
                    def __init__(self, db: SqliteDatabase, id: int):
                Severity: Minor
                Found in cozy/model/book.py - About 3 hrs to fix

                  Cyclomatic complexity is too high in method search. (15)
                  Open

                      def search(self, user_search: str):
                          # we need the main context to call methods in the main thread after the search is finished
                          main_context = GLib.MainContext.default()
                  
                          books = list({
                  Severity: Minor
                  Found in cozy/ui/search_view.py by radon

                  Cyclomatic Complexity

                  Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                  Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                  Construct Effect on CC Reasoning
                  if +1 An if statement is a single decision.
                  elif +1 The elif statement adds another decision.
                  else +0 The else statement does not cause a new decision. The decision is at the if.
                  for +1 There is a decision at the start of the loop.
                  while +1 There is a decision at the while statement.
                  except +1 Each except branch adds a new conditional path of execution.
                  finally +0 The finally block is unconditionally executed.
                  with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                  assert +1 The assert statement internally roughly equals a conditional statement.
                  Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                  Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                  Source: http://radon.readthedocs.org/en/latest/intro.html

                  Cyclomatic complexity is too high in method _load_pixbuf_from_file. (15)
                  Open

                      def _load_pixbuf_from_file(self, book):
                          """
                          Try to load the artwork from a book from image files.
                          :param book: The book to load the artwork from.
                          :return: Artwork as pixbuf object.
                  Severity: Minor
                  Found in cozy/control/artwork_cache.py by radon

                  Cyclomatic Complexity

                  Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                  Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                  Construct Effect on CC Reasoning
                  if +1 An if statement is a single decision.
                  elif +1 The elif statement adds another decision.
                  else +0 The else statement does not cause a new decision. The decision is at the if.
                  for +1 There is a decision at the start of the loop.
                  while +1 There is a decision at the while statement.
                  except +1 Each except branch adds a new conditional path of execution.
                  finally +0 The finally block is unconditionally executed.
                  with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                  assert +1 The assert statement internally roughly equals a conditional statement.
                  Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                  Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                  Source: http://radon.readthedocs.org/en/latest/intro.html

                  Cyclomatic complexity is too high in method _pass_legacy_player_events. (14)
                  Open

                      def _pass_legacy_player_events(self, event, message):
                          if event == "play":
                              self._start_tick_thread()
                          elif event == "stop" or event == "pause" or event == "closing":
                              self._stop_tick_thread()
                  Severity: Minor
                  Found in cozy/media/player.py by radon

                  Cyclomatic Complexity

                  Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                  Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                  Construct Effect on CC Reasoning
                  if +1 An if statement is a single decision.
                  elif +1 The elif statement adds another decision.
                  else +0 The else statement does not cause a new decision. The decision is at the if.
                  for +1 There is a decision at the start of the loop.
                  while +1 There is a decision at the while statement.
                  except +1 Each except branch adds a new conditional path of execution.
                  finally +0 The finally block is unconditionally executed.
                  with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                  assert +1 The assert statement internally roughly equals a conditional statement.
                  Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                  Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                  Source: http://radon.readthedocs.org/en/latest/intro.html

                  Cyclomatic complexity is too high in method __on_storage_changed. (14)
                  Open

                      def __on_storage_changed(self, event, message):
                          if (event == "storage-online" and not super().get_sensitive()) or event == "external-storage-removed":
                              if message in self.book.chapters[0].file:
                                  super().set_sensitive(True)
                                  self.box.set_tooltip_text(self.ONLINE_TOOLTIP_TEXT)
                  Severity: Minor
                  Found in cozy/ui/book_element.py by radon

                  Cyclomatic Complexity

                  Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                  Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                  Construct Effect on CC Reasoning
                  if +1 An if statement is a single decision.
                  elif +1 The elif statement adds another decision.
                  else +0 The else statement does not cause a new decision. The decision is at the if.
                  for +1 There is a decision at the start of the loop.
                  while +1 There is a decision at the while statement.
                  except +1 Each except branch adds a new conditional path of execution.
                  finally +0 The finally block is unconditionally executed.
                  with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                  assert +1 The assert statement internally roughly equals a conditional statement.
                  Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                  Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                  Source: http://radon.readthedocs.org/en/latest/intro.html

                  BookDetailViewModel has 26 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class BookDetailViewModel(Observable, EventSender):
                      _player: Player = inject.attr(Player)
                      _fs_monitor: FilesystemMonitor = inject.attr("FilesystemMonitor")
                      _offline_cache: OfflineCache = inject.attr(OfflineCache)
                      _settings: Settings = inject.attr(Settings)
                  Severity: Minor
                  Found in cozy/view_model/book_detail_view_model.py - About 3 hrs to fix

                    Cyclomatic complexity is too high in method display_book_filter. (13)
                    Open

                        def display_book_filter(self, book_element: BookElement):
                            book = book_element.book
                            swap_author_reader = self._application_settings.swap_author_reader
                            author = book.author if not swap_author_reader else book.reader
                            reader = book.reader if not swap_author_reader else book.author
                    Severity: Minor
                    Found in cozy/view_model/library_view_model.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    Cyclomatic complexity is too high in function update_db. (13)
                    Open

                    def update_db():
                        db = get_sqlite_database()
                        # First test for version 1
                        try:
                            next(c for c in db.get_columns("settings") if c.name == "version")
                    Severity: Minor
                    Found in cozy/control/db_updater.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    File settings.py has 290 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    from threading import Thread
                    import logging
                    import gi
                    
                    from cozy.control.db import remove_tracks_with_path
                    Severity: Minor
                    Found in cozy/ui/settings.py - About 2 hrs to fix

                      Cyclomatic complexity is too high in method Get. (12)
                      Open

                          def Get(self, interface, property_name):
                              if property_name in ["CanQuit", "CanRaise", "CanSeek",
                                                   "CanControl", "HasRatingsExtension"]:
                                  return GLib.Variant("b", True)
                              elif property_name == "HasTrackList":
                      Severity: Minor
                      Found in cozy/control/mpris.py by radon

                      Cyclomatic Complexity

                      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                      Construct Effect on CC Reasoning
                      if +1 An if statement is a single decision.
                      elif +1 The elif statement adds another decision.
                      else +0 The else statement does not cause a new decision. The decision is at the if.
                      for +1 There is a decision at the start of the loop.
                      while +1 There is a decision at the while statement.
                      except +1 Each except branch adds a new conditional path of execution.
                      finally +0 The finally block is unconditionally executed.
                      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                      assert +1 The assert statement internally roughly equals a conditional statement.
                      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                      Source: http://radon.readthedocs.org/en/latest/intro.html

                      Function _process_queue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def _process_queue(self):
                              log.info("Startet processing queue")
                              self.filecopy_cancel = Gio.Cancellable()
                      
                              self._fill_queue_from_db()
                      Severity: Minor
                      Found in cozy/control/offline_cache.py - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      MPRIS has 24 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class MPRIS(Server):
                          """
                          <!DOCTYPE node PUBLIC
                          "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
                          "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
                      Severity: Minor
                      Found in cozy/control/mpris.py - About 2 hrs to fix

                        Cyclomatic complexity is too high in method _process_queue. (11)
                        Open

                            def _process_queue(self):
                                log.info("Startet processing queue")
                                self.filecopy_cancel = Gio.Cancellable()
                        
                                self._fill_queue_from_db()
                        Severity: Minor
                        Found in cozy/control/offline_cache.py by radon

                        Cyclomatic Complexity

                        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                        Construct Effect on CC Reasoning
                        if +1 An if statement is a single decision.
                        elif +1 The elif statement adds another decision.
                        else +0 The else statement does not cause a new decision. The decision is at the if.
                        for +1 There is a decision at the start of the loop.
                        while +1 There is a decision at the while statement.
                        except +1 Each except branch adds a new conditional path of execution.
                        finally +0 The finally block is unconditionally executed.
                        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                        assert +1 The assert statement internally roughly equals a conditional statement.
                        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                        Source: http://radon.readthedocs.org/en/latest/intro.html

                        Severity
                        Category
                        Status
                        Source
                        Language