Sign upLogin

geigi/cozy

View on GitHub
Star

Showing 100 of 195 total issues

File main_view.py has 714 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import webbrowser

import gi

from cozy.control.db import books, authors, readers, is_external, close_db
Severity: Major
Found in cozy/ui/main_view.py - About 1 day to fix

    File importer.py has 589 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import os
import base64
import urllib
import urllib.parse
import shutil
    Severity: Major
    Found in cozy/control/importer.py - About 1 day to fix

      Function update_database has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
      Open

      def update_database(ui, force=False):
    """
    Scans the audio book directory for changes and new files.
    Also removes entries from the db that are no longer existent.
    """
      Severity: Minor
      Found in cozy/control/importer.py - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      CozyUI has 51 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class CozyUI(metaclass=Singleton):
    """
    CozyUI is the main ui class.
    """
    # The book that is currently loaded in the player
      Severity: Major
      Found in cozy/ui/main_view.py - About 7 hrs to fix

        File player.py has 446 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import threading
import time
from gi.repository import Gst

import gi
        Severity: Minor
        Found in cozy/control/player.py - About 6 hrs to fix

          File book_element.py has 416 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import os, subprocess
from gi.repository import Gtk, Gdk, GdkPixbuf, Pango, Gst

import cozy.control.player as player
import cozy.tools as tools
          Severity: Minor
          Found in cozy/ui/book_element.py - About 6 hrs to fix

            File titlebar.py has 381 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import cozy.control.artwork_cache as artwork_cache
import cozy.control.player as player
import cozy.tools as tools
import cozy.ui
from cozy.control.db import get_book_remaining, get_book_progress, get_track_from_book_time, get_book_duration
            Severity: Minor
            Found in cozy/ui/titlebar.py - About 5 hrs to fix

              File settings.py has 381 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              from threading import Thread
import logging
import gi

from cozy.control.db import remove_tracks_with_path
              Severity: Minor
              Found in cozy/ui/settings.py - About 5 hrs to fix

                Function __filter_books has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                Open

                    def __filter_books(self, book, data, notify_destroy):
        """
        Filter the books in the book view according to the selected author/reader or "All".
        """
        selected_stack = self.sort_stack.props.visible_child_name
                Severity: Minor
                Found in cozy/ui/main_view.py - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function import_file has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                Open

                def import_file(file, directory, path, update=False):
    """
    Imports all information about a track into the database.
    Note: This creates also a new album object when it doesnt exist yet.
    Note: This does not check whether the file is already imported.
                Severity: Minor
                Found in cozy/control/importer.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function filter_author_reader has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                Open

                    def filter_author_reader(self, hide_offline):
        """
        This method filters unavailable (offline) author and readers from
        the list boxes.
        """
                Severity: Minor
                Found in cozy/ui/main_view.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File mpris.py has 329 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # Forked from https://github.com/gnumdk/lollypop/blob/master/lollypop/mpris.py
# copyright (c) 2014-2017 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
# copyright (c) 2016 Gaurav Narula
# copyright (c) 2016 Felipe Borges <felipeborges@gnome.org>
# copyright (c) 2013 Arnel A. Borja <kyoushuu@yahoo.com>
                Severity: Minor
                Found in cozy/control/mpris.py - About 3 hrs to fix

                  Titlebar has 30 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Titlebar:
    """
    This class contains all titlebar logic.
    """
    # main ui class
                  Severity: Minor
                  Found in cozy/ui/titlebar.py - About 3 hrs to fix

                    File db.py has 296 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import logging
import os
import time

from cozy.control.db_updater import update_db
                    Severity: Minor
                    Found in cozy/control/db.py - About 3 hrs to fix

                      Function seconds_to_str has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def seconds_to_str(seconds, include_seconds=True, display_zero_h=False):
    """
    Converts seconds to a string with the following apperance:
    hh:mm:ss
                      Severity: Minor
                      Found in cozy/tools.py - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File book_overview.py has 287 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      from gi.repository import Gtk, Gdk, Gst

import cozy.control.artwork_cache as artwork_cache
import cozy.tools as tools
import cozy.control.player as player
                      Severity: Minor
                      Found in cozy/ui/book_overview.py - About 2 hrs to fix

                        Function seconds_to_human_readable has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def seconds_to_human_readable(seconds):
    """
    Create a string with the following format:
    6 hours 1 minute
    45 minutes
                        Severity: Minor
                        Found in cozy/tools.py - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _process_queue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def _process_queue(self):
        log.info("Startet processing queue")
        self.filecopy_cancel = Gio.Cancellable()
        
        self._fill_queue_from_db()
                        Severity: Minor
                        Found in cozy/control/offline_cache.py - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        MPRIS has 24 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class MPRIS(Server):
    """
    <!DOCTYPE node PUBLIC
    "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
    "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
                        Severity: Minor
                        Found in cozy/control/mpris.py - About 2 hrs to fix

                          Function __player_changed has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def __player_changed(self, event, message):
        """
        Listen to and handle all gst player messages that are important for the ui.
        """
        if event == "stop":
                          Severity: Minor
                          Found in cozy/ui/main_view.py - About 2 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language