Showing 106 of 192 total issues

File importer.py has 592 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import base64
import urllib
import urllib.parse
import shutil
Severity: Major
Found in cozy/control/importer.py - About 1 day to fix

    Function update_database has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

    def update_database(ui, force=False):
        """
        Scans the audio book directory for changes and new files.
        Also removes entries from the db that are no longer existent.
        """
    Severity: Minor
    Found in cozy/control/importer.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File main_view.py has 504 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import webbrowser
    
    from cozy.control.db import books, close_db
    from cozy.db.book import Book
    from cozy.db.storage import Storage
    Severity: Major
    Found in cozy/ui/main_view.py - About 1 day to fix

      File player.py has 467 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import threading
      import time
      from gi.repository import Gst, GLib
      
      import gi
      Severity: Minor
      Found in cozy/control/player.py - About 7 hrs to fix

        CozyUI has 43 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class CozyUI(metaclass=Singleton):
            """
            CozyUI is the main ui class.
            """
            # The book that is currently loaded in the player
        Severity: Minor
        Found in cozy/ui/main_view.py - About 5 hrs to fix

          File settings.py has 396 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          from threading import Thread
          import logging
          import gi
          
          from cozy.control.db import remove_tracks_with_path
          Severity: Minor
          Found in cozy/ui/settings.py - About 5 hrs to fix

            File titlebar.py has 391 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import cozy.control.artwork_cache as artwork_cache
            import cozy.control.player as player
            import cozy.tools as tools
            import cozy.ui
            from cozy.control.db import get_book_remaining, get_book_progress, get_track_from_book_time, get_book_duration
            Severity: Minor
            Found in cozy/ui/titlebar.py - About 5 hrs to fix

              Function import_file has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
              Open

              def import_file(file, directory, path, update=False):
                  """
                  Imports all information about a track into the database.
                  Note: This creates also a new album object when it doesnt exist yet.
                  Note: This does not check whether the file is already imported.
              Severity: Minor
              Found in cozy/control/importer.py - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File mpris.py has 341 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # Forked from https://github.com/gnumdk/lollypop/blob/master/lollypop/mpris.py
              # copyright (c) 2014-2017 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
              # copyright (c) 2016 Gaurav Narula
              # copyright (c) 2016 Felipe Borges <felipeborges@gnome.org>
              # copyright (c) 2013 Arnel A. Borja <kyoushuu@yahoo.com>
              Severity: Minor
              Found in cozy/control/mpris.py - About 4 hrs to fix

                Titlebar has 31 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Titlebar:
                    """
                    This class contains all titlebar logic.
                    """
                    # main ui class
                Severity: Minor
                Found in cozy/ui/titlebar.py - About 3 hrs to fix

                  Book has 28 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Book:
                      _chapters: List[Chapter] = None
                  
                      def __init__(self, db: SqliteDatabase, id: int):
                          self._db: SqliteDatabase = db
                  Severity: Minor
                  Found in cozy/model/book.py - About 3 hrs to fix

                    File book_overview.py has 282 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    from gi.repository import Gtk, Gdk, Gst
                    
                    import cozy.control.artwork_cache as artwork_cache
                    import cozy.tools as tools
                    import cozy.control.player as player
                    Severity: Minor
                    Found in cozy/ui/book_overview.py - About 2 hrs to fix

                      Function seconds_to_human_readable has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def seconds_to_human_readable(seconds):
                          """
                          Create a string with the following format:
                          6 hours 1 minute
                          45 minutes
                      Severity: Minor
                      Found in cozy/tools.py - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function _process_queue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def _process_queue(self):
                              log.info("Startet processing queue")
                              self.filecopy_cancel = Gio.Cancellable()
                      
                              self._fill_queue_from_db()
                      Severity: Minor
                      Found in cozy/control/offline_cache.py - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      MPRIS has 24 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class MPRIS(Server):
                          """
                          <!DOCTYPE node PUBLIC
                          "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
                          "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
                      Severity: Minor
                      Found in cozy/control/mpris.py - About 2 hrs to fix

                        File magic.py has 267 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        """
                        Copyright: https://github.com/ahupp/python-magic
                        This library is included by cozy due to different packages with the same name (magic) being available 
                        across distros. This is messy but because the whole situation is messy it seems like the best solution for now.
                        magic is a wrapper around the libmagic file identification library.
                        Severity: Minor
                        Found in cozy/magic/magic.py - About 2 hrs to fix

                          Function set_book has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def set_book(self, book):
                                  """
                                  Display the given book in the book overview.
                                  """
                                  if self.book and self.book.id == book.id:
                          Severity: Minor
                          Found in cozy/ui/book_overview.py - About 2 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function init_db has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def init_db():
                              tmp_db = None
                          
                              _connect_db(_db)
                          
                          
                          Severity: Minor
                          Found in cozy/control/db.py - About 2 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Settings has 21 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class Settings(EventSender, metaclass=Singleton):
                              """
                              This class contains all logic for cozys preferences.
                              """
                              view_model = None
                          Severity: Minor
                          Found in cozy/ui/settings.py - About 2 hrs to fix

                            Function __load_pixbuf_from_file has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def __load_pixbuf_from_file(book):
                                """
                                Try to load the artwork from a book from image files.
                                :param book: The book to load the artwork from.
                                :return: Artwork as pixbuf object.
                            Severity: Minor
                            Found in cozy/control/artwork_cache.py - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language