Showing 94 of 151 total issues

Function update_database has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

def update_database(ui, force=False):
    """
    Scans the audio book directory for changes and new files.
    Also removes entries from the db that are no longer existent.
    """
Severity: Minor
Found in cozy/control/importer.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

CozyUI has 51 functions (exceeds 20 allowed). Consider refactoring.
Open

class CozyUI(metaclass=Singleton):
    """
    CozyUI is the main ui class.
    """
    # The book that is currently loaded in the player
Severity: Major
Found in cozy/ui/main_view.py - About 7 hrs to fix

    Function __filter_books has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def __filter_books(self, book, data, notify_destroy):
            """
            Filter the books in the book view according to the selected author/reader or "All".
            """
            selected_stack = self.sort_stack.props.visible_child_name
    Severity: Minor
    Found in cozy/ui/main_view.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function import_file has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    def import_file(file, directory, path, update=False, crc=None):
        """
        Imports all information about a track into the database.
        Note: This creates also a new album object when it doesnt exist yet.
        Note: This does not check whether the file is already imported.
    Severity: Minor
    Found in cozy/control/importer.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function filter_author_reader has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter_author_reader(self, hide_offline):
            """
            This method filters unavailable (offline) author and readers from
            the list boxes.
            """
    Severity: Minor
    Found in cozy/ui/main_view.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Titlebar has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Titlebar:
        """
        This class contains all titlebar logic.
        """
        # main ui class
    Severity: Minor
    Found in cozy/ui/titlebar.py - About 3 hrs to fix

      Function seconds_to_str has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

      def seconds_to_str(seconds, include_seconds=True, display_zero_h=False):
          """
          Converts seconds to a string with the following apperance:
          hh:mm:ss
      
      
      Severity: Minor
      Found in cozy/tools.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _process_queue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          def _process_queue(self):
              log.info("Startet processing queue")
              self.filecopy_cancel = Gio.Cancellable()
              
              self._fill_queue_from_db()
      Severity: Minor
      Found in cozy/control/offline_cache.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function seconds_to_human_readable has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      def seconds_to_human_readable(seconds):
          """
          Create a string with the following format:
          6 hours 1 minute
          45 minutes
      Severity: Minor
      Found in cozy/tools.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      MPRIS has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class MPRIS(Server):
          """
          <!DOCTYPE node PUBLIC
          "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
          "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
      Severity: Minor
      Found in cozy/control/mpris.py - About 2 hrs to fix

        Function __player_changed has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def __player_changed(self, event, message):
                """
                Listen to and handle all gst player messages that are important for the ui.
                """
                if event == "stop":
        Severity: Minor
        Found in cozy/ui/main_view.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function init_db has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        def init_db():
            global db
            global update
            global data_dir
        
        
        Severity: Minor
        Found in cozy/control/db.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function set_book has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            def set_book(self, book):
                """
                Display the given book in the book overview.
                """
                if self.book and self.book.id == book.id:
        Severity: Minor
        Found in cozy/ui/book_overview.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function load_last_book has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        def load_last_book():
            """
            Load the last played book into the player.
            """
            global __current_track
        Severity: Minor
        Found in cozy/control/player.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __load_pixbuf_from_file has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        def __load_pixbuf_from_file(book):
            """
            Try to load the artwork from a book from image files.
            :param book: The book to load the artwork from.
            :return: Artwork as pixbuf object.
        Severity: Minor
        Found in cozy/control/artwork_cache.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def __init__(self, book, size, scale, bordered=False, square=False):
                """
                :param size: the size for the longer side of the image
                :param bordered: should there be a border around the album art?
                :param square: should the widget be always a square?
        Severity: Major
        Found in cozy/ui/book_element.py - About 2 hrs to fix

          Function __init_window has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def __init_window(self):
                  """
                  Add fields for all ui objects we need to access from code.
                  Initialize everything we can't do from glade like events and other stuff.
                  """
          Severity: Minor
          Found in cozy/ui/main_view.py - About 1 hr to fix

            Function __init__ has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def __init__(self, t, book):
                    self.track = t
                    self.ui = cozy.ui.main_view.CozyUI()
                    self.book = book
            
            
            Severity: Minor
            Found in cozy/ui/book_element.py - About 1 hr to fix

              Function __on_storage_changed has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __on_storage_changed(self, event, message):
                      """
                      """
                      if (event == "storage-online" and not super().get_sensitive()) or event == "external-storage-removed":
                          if message in db.tracks(self.book).first().file:
              Severity: Minor
              Found in cozy/ui/book_element.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function copy_to_audiobook_folder has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

              def copy_to_audiobook_folder(path):
                  """
                  Copies the given path (folder or file) to the audio book folder.
                  """
                  try:
              Severity: Minor
              Found in cozy/control/importer.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language