Showing 89 of 159 total issues
Player
has 39 functions (exceeds 20 allowed). Consider refactoring. Open
class Player(EventSender):
_library: Library = inject.attr(Library)
_app_settings: ApplicationSettings = inject.attr(ApplicationSettings)
_offline_cache: OfflineCache = inject.attr(OfflineCache)
_info_bar: InfoBanner = inject.attr(InfoBanner)
File __init__.py
has 370 lines of code (exceeds 250 allowed). Consider refactoring. Open
"""
Python dependency injection framework.
Usage:
- Create an optional configuration::
ApplicationSettings
has 34 functions (exceeds 20 allowed). Consider refactoring. Open
class ApplicationSettings(EventSender):
_settings: Gio.Settings = inject.attr(Gio.Settings)
def __init__(self):
super().__init__()
File mpris.py
has 346 lines of code (exceeds 250 allowed). Consider refactoring. Open
# Forked from https://github.com/gnumdk/lollypop/blob/master/lollypop/mpris.py
# copyright (c) 2014-2017 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
# copyright (c) 2016 Gaurav Narula
# copyright (c) 2016 Felipe Borges <felipeborges@gnome.org>
# copyright (c) 2013 Arnel A. Borja <kyoushuu@yahoo.com>
CozyUI
has 31 functions (exceeds 20 allowed). Consider refactoring. Open
class CozyUI(EventSender, metaclass=Singleton):
"""
CozyUI is the main ui class.
"""
# Is currently an dialog open?
BookDetailView
has 31 functions (exceeds 20 allowed). Consider refactoring. Open
class BookDetailView(Gtk.EventBox):
__gtype_name__ = 'BookDetail'
play_book_button: Gtk.Button = Gtk.Template.Child()
play_img: Gtk.Image = Gtk.Template.Child()
File player.py
has 321 lines of code (exceeds 250 allowed). Consider refactoring. Open
import logging
import os
import time
from threading import Thread
from typing import Optional
File main_view.py
has 317 lines of code (exceeds 250 allowed). Consider refactoring. Open
import logging
import os
import webbrowser
from threading import Thread
BookDetailViewModel
has 29 functions (exceeds 20 allowed). Consider refactoring. Open
class BookDetailViewModel(Observable, EventSender):
_player: Player = inject.attr(Player)
_fs_monitor: FilesystemMonitor = inject.attr("FilesystemMonitor")
_offline_cache: OfflineCache = inject.attr(OfflineCache)
_settings: Settings = inject.attr(Settings)
LibraryViewModel
has 29 functions (exceeds 20 allowed). Consider refactoring. Open
class LibraryViewModel(Observable, EventSender):
_application_settings: ApplicationSettings = inject.attr(ApplicationSettings)
_fs_monitor: FilesystemMonitor = inject.attr("FilesystemMonitor")
_model = inject.attr(Library)
_importer: Importer = inject.attr(Importer)
Book
has 28 functions (exceeds 20 allowed). Consider refactoring. Open
class Book(Observable, EventSender):
_chapters: List[Chapter] = None
_settings: Settings = inject.attr(Settings)
_app_settings: ApplicationSettings = inject.attr(ApplicationSettings)
Function _process_queue
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
def _process_queue(self):
log.info("Started processing queue")
self.filecopy_cancel = Gio.Cancellable()
self._fill_queue_from_db()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _update_db_9
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def _update_db_9(db):
log.info("Migrating to DB Version 9...")
models = generate_models(db)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
MPRIS
has 25 functions (exceeds 20 allowed). Consider refactoring. Open
class MPRIS(Server):
"""
<!DOCTYPE node PUBLIC
"-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
Function update_db
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def update_db():
db = get_sqlite_database()
# First test for version 1
try:
next(c for c in db.get_columns("settings") if c.name == "version")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __call__
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def __call__(self, func: Callable[..., Union[Awaitable[T], T]]) -> Callable[..., Union[Awaitable[T], T]]:
if sys.version_info.major == 2:
arg_names = inspect.getargspec(func).args
else:
arg_names = inspect.getfullargspec(func).args
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File db_updater.py
has 257 lines of code (exceeds 250 allowed). Consider refactoring. Open
import logging
import os
import shutil
from datetime import datetime
from typing import List
MediaControllerBig
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class MediaControllerBig(Gtk.Box):
__gtype_name__ = "MediaControllerBig"
seek_bar_container: Gtk.Box = Gtk.Template.Child()
LibraryView
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class LibraryView:
_view_model: LibraryViewModel = inject.attr(LibraryViewModel)
def __init__(self, builder: Builder):
self._builder = builder
Track
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class Track(Chapter):
def __init__(self, db: SqliteDatabase, track: TrackModel):
super().__init__()
self._db: SqliteDatabase = db
self.id: int = track.id