Sign upLogin

gfw-api/arcgis-proxy

View on GitHub
Star

Showing 8 of 14 total issues

Function validate_imageserver has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def validate_imageserver(func):
    """serviceUrl parameter must be a valid ArcGIS Image Server instance"""

    @wraps(func)
    def wrapper(*args, **kwargs):
Severity: Minor
Found in arcgis_proxy/validators.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return error(status=400, detail="Not a valid Image Service URL")
Severity: Major
Found in arcgis_proxy/validators.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return v
    Severity: Major
    Found in arcgis_proxy/validators.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return v
      Severity: Major
      Found in arcgis_proxy/validators.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return func(*args, **kwargs)
        Severity: Major
        Found in arcgis_proxy/validators.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return error(status=400, detail=e)
          Severity: Major
          Found in arcgis_proxy/validators.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return error(status=400, detail="Not a valid Image Service URL")
            Severity: Major
            Found in arcgis_proxy/validators.py - About 30 mins to fix

              Function worker_int has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def worker_int(worker):
    worker.log.info("worker received INT or QUIT signal")

    ## get traceback info
    import threading, sys, traceback
              Severity: Minor
              Found in gunicorn.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language