gfw-api/arcgis-proxy

View on GitHub

Showing 6 of 14 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 116..118
arcgis_proxy/validators.py on lines 121..123
arcgis_proxy/validators.py on lines 131..133
arcgis_proxy/validators.py on lines 136..138
arcgis_proxy/validators.py on lines 141..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 116..118
arcgis_proxy/validators.py on lines 121..123
arcgis_proxy/validators.py on lines 126..128
arcgis_proxy/validators.py on lines 136..138
arcgis_proxy/validators.py on lines 141..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 121..123
arcgis_proxy/validators.py on lines 126..128
arcgis_proxy/validators.py on lines 131..133
arcgis_proxy/validators.py on lines 136..138
arcgis_proxy/validators.py on lines 141..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 116..118
arcgis_proxy/validators.py on lines 121..123
arcgis_proxy/validators.py on lines 126..128
arcgis_proxy/validators.py on lines 131..133
arcgis_proxy/validators.py on lines 141..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 116..118
arcgis_proxy/validators.py on lines 121..123
arcgis_proxy/validators.py on lines 126..128
arcgis_proxy/validators.py on lines 131..133
arcgis_proxy/validators.py on lines 136..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        if v:
            logging.debug('[VALIDATOR]: {}'.format(json.loads(v[0].data)))
            return v
Severity: Major
Found in arcgis_proxy/validators.py and 5 other locations - About 50 mins to fix
arcgis_proxy/validators.py on lines 116..118
arcgis_proxy/validators.py on lines 126..128
arcgis_proxy/validators.py on lines 131..133
arcgis_proxy/validators.py on lines 136..138
arcgis_proxy/validators.py on lines 141..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language