gfw-api/fw-teams

View on GitHub

Showing 9 of 18 total issues

Function exports has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (grunt) => {

    grunt.file.setBase('..');
    // eslint-disable-next-line import/no-extraneous-dependencies
    require('load-grunt-tasks')(grunt);
Severity: Major
Found in app/Gruntfile.js - About 2 hrs to fix

    Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (() => {
    
        const loadAPI = (app, path, pathApi) => {
            const routesFiles = fs.readdirSync(path);
            let existIndexRouter = false;
    Severity: Minor
    Found in app/src/loader.js - About 1 hr to fix

      Function update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async update(ctx) {
              logger.info(`Updating team with id ${ctx.params.id}`);
              const includes = (container, value) => container.indexOf(value) >= 0;
              const { body } = ctx.request;
              const userId = body.loggedUser.id;
      Severity: Minor
      Found in app/src/routes/api/v1/team.router.js - About 1 hr to fix

        Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const loadAPI = (app, path, pathApi) => {
                const routesFiles = fs.readdirSync(path);
                let existIndexRouter = false;
                routesFiles.forEach((file) => {
                    const newPath = path ? (`${path}/${file}`) : file;
        Severity: Minor
        Found in app/src/loader.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = (() => {
          
              const loadAPI = (app, path, pathApi) => {
                  const routesFiles = fs.readdirSync(path);
                  let existIndexRouter = false;
          Severity: Minor
          Found in app/src/loader.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              static async update(ctx) {
                  logger.info(`Updating team with id ${ctx.params.id}`);
                  const includes = (container, value) => container.indexOf(value) >= 0;
                  const { body } = ctx.request;
                  const userId = body.loggedUser.id;
          Severity: Minor
          Found in app/src/routes/api/v1/team.router.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              static async create(ctx, next) {
                  const isArrayToErrors = (field) => {
                      const value = ctx.request.body[field];
                      if (typeof value !== 'undefined' && !Array.isArray(value)) {
                          const newError = { [field]: `${field} should be an Array.` };
          Severity: Minor
          Found in app/src/validators/team.validator.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              static async update(ctx, next) {
                  const isArrayToErrors = (field) => {
                      const value = ctx.request.body[field];
                      if (typeof value !== 'undefined' && !Array.isArray(value)) {
                          const newError = { [field]: `${field} should be an Array.` };
          Severity: Minor
          Found in app/src/validators/team.validator.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function confirmUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              static async confirmUser(ctx) {
                  const { token } = ctx.params;
                  logger.info('Confirming user with token', token);
                  const loggedUser = JSON.parse(ctx.request.query.loggedUser);
                  const userId = loggedUser.id;
          Severity: Minor
          Found in app/src/routes/api/v1/team.router.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language