gfw-api/gfw-forma-alerts-api

View on GitHub

Showing 13 of 25 total issues

Function init has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const init: () => Promise<IInit> = async (): Promise<IInit> => {
    return new Promise((resolve: (value: IInit | PromiseLike<IInit>) => void
    ) => {

        const app: Koa = new Koa();
Severity: Major
Found in src/app.ts - About 2 hrs to fix

    File cartoDBService.ts has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import config from 'config';
    import logger from 'logger';
    import Mustache from 'mustache';
    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
    // @ts-ignore
    Severity: Minor
    Found in src/services/cartoDBService.ts - About 2 hrs to fix

      Function use has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async use(ctx: Context): Promise<void> {
              logger.info('Obtaining use data with name %s and id %s', ctx.params.name, ctx.params.id);
              let useTable: string = null;
              switch (ctx.params.name) {
      
      
      Severity: Minor
      Found in src/routes/formaAlerts.router.ts - About 1 hr to fix

        Function getSubnational has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async getSubnational(iso: string, id1: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                logger.debug('Obtaining subnational of iso %s and id1', iso, id1);
                const periods: string[] = period.split(',');
                const params: { iso: any; id1: any; end: string; begin: string } = {
                    iso,
        Severity: Minor
        Found in src/services/cartoDBService.ts - About 1 hr to fix

          Function getUse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async getUse(useName: string, useTable: string, id: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                  logger.debug('Obtaining use with id %s', id);
                  const periods: string[] = period.split(',');
                  const params: { pid: any; end: string; useTable: any; begin: string } = {
                      useTable,
          Severity: Minor
          Found in src/services/cartoDBService.ts - About 1 hr to fix

            Function getNational has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                async getNational(iso: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                    logger.debug('Obtaining national of iso %s', iso);
                    const periods: string[] = period.split(',');
                    const params: { iso: string; end: string; begin: string } = {
                        iso,
            Severity: Minor
            Found in src/services/cartoDBService.ts - About 1 hr to fix

              Function getWdpa has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  async getWdpa(wdpaid: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                      logger.debug('Obtaining wpda of id %s', wdpaid);
                      const periods: string[] = period.split(',');
                      const params: { end: string; begin: string; wdpaid: any } = {
                          wdpaid,
              Severity: Minor
              Found in src/services/cartoDBService.ts - About 1 hr to fix

                Function getWorldWithGeojson has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    async getWorldWithGeojson(geojson: Record<string, any>, forSubscription: string, period: string = defaultDate(), areaHa: string = null): Promise<Record<string, any> | void> {
                        logger.debug('Executing query in cartodb with geojson', geojson);
                        const periods: string[] = period.split(',');
                        const params: { geojson: string; end: string; begin: string } = {
                            geojson: JSON.stringify(geojson.features[0].geometry),
                Severity: Minor
                Found in src/services/cartoDBService.ts - About 1 hr to fix

                  Function getWorldWithGeojson has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      async getWorldWithGeojson(geojson: Record<string, any>, forSubscription: string, period: string = defaultDate(), areaHa: string = null): Promise<Record<string, any> | void> {
                          logger.debug('Executing query in cartodb with geojson', geojson);
                          const periods: string[] = period.split(',');
                          const params: { geojson: string; end: string; begin: string } = {
                              geojson: JSON.stringify(geojson.features[0].geometry),
                  Severity: Minor
                  Found in src/services/cartoDBService.ts - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getNational has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      async getNational(iso: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                          logger.debug('Obtaining national of iso %s', iso);
                          const periods: string[] = period.split(',');
                          const params: { iso: string; end: string; begin: string } = {
                              iso,
                  Severity: Minor
                  Found in src/services/cartoDBService.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getSubnational has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      async getSubnational(iso: string, id1: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                          logger.debug('Obtaining subnational of iso %s and id1', iso, id1);
                          const periods: string[] = period.split(',');
                          const params: { iso: any; id1: any; end: string; begin: string } = {
                              iso,
                  Severity: Minor
                  Found in src/services/cartoDBService.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getUse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      async getUse(useName: string, useTable: string, id: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                          logger.debug('Obtaining use with id %s', id);
                          const periods: string[] = period.split(',');
                          const params: { pid: any; end: string; useTable: any; begin: string } = {
                              useTable,
                  Severity: Minor
                  Found in src/services/cartoDBService.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getWdpa has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      async getWdpa(wdpaid: string, forSubscription: string, period: string = defaultDate(), apiKey: string): Promise<Record<string, any> | void> {
                          logger.debug('Obtaining wpda of id %s', wdpaid);
                          const periods: string[] = period.split(',');
                          const params: { end: string; begin: string; wdpaid: any } = {
                              wdpaid,
                  Severity: Minor
                  Found in src/services/cartoDBService.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language