gfw-api/gfw-viirs-fires-api

View on GitHub

Showing 7 of 33 total issues

Function exports has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (grunt) => {

    grunt.file.setBase('..');
    // eslint-disable-next-line import/no-extraneous-dependencies
    require('load-grunt-tasks')(grunt);
Severity: Major
Found in app/Gruntfile.js - About 3 hrs to fix

    Function getViirsAlerts has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        static async getViirsAlerts(alertQuery, queryParams, datasetIds, period, forSubscription, group, areaQuery = null, geostore = null) {
            if (forSubscription) {
                const query = getURLForSubscription(alertQuery);
                const result = await DatasetService.queryDataset(datasetIds.all, query, queryParams, geostore);
                return result.data;
    Severity: Minor
    Found in app/src/services/datasetService.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getViirsAlerts has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async getViirsAlerts(alertQuery, queryParams, datasetIds, period, forSubscription, group, areaQuery = null, geostore = null) {
            if (forSubscription) {
                const query = getURLForSubscription(alertQuery);
                const result = await DatasetService.queryDataset(datasetIds.all, query, queryParams, geostore);
                return result.data;
    Severity: Minor
    Found in app/src/services/datasetService.js - About 1 hr to fix

      Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = (() => {
      
          const loadAPI = (app, path, pathApi) => {
              const routesFiles = fs.readdirSync(path);
              let existIndexRouter = false;
      Severity: Minor
      Found in app/src/loader.js - About 1 hr to fix

        Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const loadAPI = (app, path, pathApi) => {
                const routesFiles = fs.readdirSync(path);
                let existIndexRouter = false;
                routesFiles.forEach((file) => {
                    const newPath = path ? (`${path}/${file}`) : file;
        Severity: Minor
        Found in app/src/loader.js - About 1 hr to fix

          Function getAdm has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static async getAdm(iso, forSubscription, period = defaultDate(), group = false, adm1 = null, adm2 = null) {
                  logger.debug('Obtaining national of iso %s and period %s', iso, period);
                  const periods = period.split(',');
                  const params = {
                      iso,
          Severity: Minor
          Found in app/src/services/datasetService.js - About 1 hr to fix

            Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = (() => {
            
                const loadAPI = (app, path, pathApi) => {
                    const routesFiles = fs.readdirSync(path);
                    let existIndexRouter = false;
            Severity: Minor
            Found in app/src/loader.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language