Sign upLogin

gfw-api/true-color-tiles

View on GitHub
Star

Showing 10 of 10 total issues

Function init has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const init: () => Promise<IInit> = async (): Promise<IInit> => {
    return new Promise((resolve: (value: IInit | PromiseLike<IInit>) => void
    ): void => {
        const app: Koa = new Koa();
Severity: Minor
Found in src/app.ts - About 1 hr to fix

    Function getImage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async getImage(reqCtx: Context): Promise<Buffer> {
        logger.info('Getting url');

        const { params } = reqCtx;
        const url: string = this.getUrl(params.urlTemplate, this.getTileCoords(params.x, params.y, params.z));
    Severity: Minor
    Found in src/services/image.service.ts - About 1 hr to fix

      Function decodeGLAD has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          static decodeGLAD(data: any, ctx: Context): any {

        const q: Record<string, any> = ctx.query;

        const startDate: number = (q.startDate === undefined) ? 0 : ImageService.dateToInt(q.startDate, 0);
      Severity: Minor
      Found in src/services/image.service.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function dateToInt has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static dateToInt(yearStr: string, defaultvalue: number): number {

        function isLeapYear(year: number): boolean {
            return !(year % 4);
        }
      Severity: Minor
      Found in src/services/image.service.ts - About 1 hr to fix

        Function decodeLoss has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            static decodeLoss(data: any, ctx: Context): any {
        const { z } = ctx.params;
        const q: any = ctx.query;

        const startYear: number = (q.startYear === undefined) ? 0 : ImageService.yearToInt(q.startYear);
        Severity: Minor
        Found in src/services/image.service.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function returnPromise has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    const returnPromise: Promise<Buffer> = new Promise((resolve: (value: any) => void): void => {
                img.onerror = (err: Error):void => {
                    throw err
                };
                img.onload = (): void => {
        Severity: Minor
        Found in src/services/image.service.ts - About 1 hr to fix

          Function dateToInt has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              static dateToInt(yearStr: string, defaultvalue: number): number {

        function isLeapYear(year: number): boolean {
            return !(year % 4);
        }
          Severity: Minor
          Found in src/services/image.service.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  const srcX: number = (256 / Math.pow(2, zsteps) * (params.x % Math.pow(2, zsteps))) | 0;
          Severity: Minor
          Found in src/services/image.service.ts and 1 other location - About 40 mins to fix
          src/services/image.service.ts on lines 200..200

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                  const srcY: number = (256 / Math.pow(2, zsteps) * (params.y % Math.pow(2, zsteps))) | 0;
          Severity: Minor
          Found in src/services/image.service.ts and 1 other location - About 40 mins to fix
          src/services/image.service.ts on lines 199..199

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getTileCoords has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              static getTileCoords(x: number, y: number, z: number): number[] {
        if (z > dataMaxZoom) {
            x = Math.floor(x / (Math.pow(2, z - dataMaxZoom)));
            y = Math.floor(y / (Math.pow(2, z - dataMaxZoom)));
            z = dataMaxZoom;
          Severity: Minor
          Found in src/services/image.service.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language