Sign upLogin

gin0115/WPUnit_Helpers

View on GitHub
Star

Showing 6 of 6 total issues

Function recursive_rmdir has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static function recursive_rmdir( string $dir ): void {
        if ( is_dir( $dir ) ) {
            $contents = scandir( $dir );

            // Loop through contents.
Severity: Minor
Found in src/Utils.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method install_remote_plugin_from_zip has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function install_remote_plugin_from_zip( string $url, string $wp_base_path ): bool {
        // Convert errors to exceptions.
        \set_error_handler( array( self::class, 'exception_error_handler' ) );

        Output::println( '' );
Severity: Minor
Found in src/WP/WP_Dependencies.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function find_post_meta( string $post_type, string $meta_key ): ?Meta_Data_Entity {
        $results = Arr\filterAnd(
            F\propertyEquals( 'meta_type', 'post' ),
            F\propertyEquals( 'sub_type', $post_type ),
            F\propertyEquals( 'meta_key', $meta_key )
    Severity: Major
    Found in src/WP/Meta_Data_Inspector.php and 1 other location - About 1 hr to fix
    src/WP/Meta_Data_Inspector.php on lines 194..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function find_term_meta( string $taxonomy, string $term_meta ): ?Meta_Data_Entity {
        $results = Arr\filterAnd(
            F\propertyEquals( 'meta_type', 'term' ),
            F\propertyEquals( 'sub_type', $taxonomy ),
            F\propertyEquals( 'meta_key', $term_meta )
    Severity: Major
    Found in src/WP/Meta_Data_Inspector.php and 1 other location - About 1 hr to fix
    src/WP/Meta_Data_Inspector.php on lines 159..168

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function update( $table, $data, $where, $format = null, $where_format = null ) {
    Severity: Minor
    Found in src/WP/Logable_WPDB.php - About 35 mins to fix

      Function install_remote_plugin_from_zip has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function install_remote_plugin_from_zip( string $url, string $wp_base_path ): bool {
        // Convert errors to exceptions.
        \set_error_handler( array( self::class, 'exception_error_handler' ) );

        Output::println( '' );
      Severity: Minor
      Found in src/WP/WP_Dependencies.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language