Showing 58 of 79 total issues
Function TestListenAndServe_proxyProtocolEnabled
has 151 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestListenAndServe_proxyProtocolEnabled(t *testing.T) {
testRoot := testhelper.PrepareTestRootDir(t)
target, err := net.ResolveTCPAddr("tcp", serverUrl)
require.NoError(t, err)
Function setup
has 138 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func setup(t *testing.T, keyId string, repo string, op string) (string, *Command, *pktline.Pktline, *io.PipeReader) {
var url string
gitalyAddress, _ := testserver.StartGitalyServer(t, "unix")
requests := []testserver.TestRequestHandler{
Function TestParseSuccess
has 132 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestParseSuccess(t *testing.T) {
testCases := []struct {
desc string
executable *executable.Executable
env sshenv.Env
Function TestExecute
has 106 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestExecute(t *testing.T) {
setup(t)
url := testserver.StartSocketHttpServer(t, requests)
File lfstransfer_test.go
has 527 lines of code (exceeds 500 allowed). Consider refactoring. Open
Open
package lfstransfer
import (
"context"
"crypto/hmac"
Function TestLfsAuthenticateRequests
has 87 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestLfsAuthenticateRequests(t *testing.T) {
userId := "123"
operation := "upload"
requests := []testserver.TestRequestHandler{
Function TestUserCertificateHandling
has 82 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestUserCertificateHandling(t *testing.T) {
testRoot := testhelper.PrepareTestRootDir(t)
validUserCert := userCert(t, ssh.UserCert, time.Now().Add(time.Hour))
Method mock_server
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
Open
def mock_server(server)
server.mount_proc('/api/v4/internal/lfs_authenticate') do |req, res|
res.content_type = 'application/json'
key_id = req.query['key_id'] || req.query['user_id']
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function TestHandleShell
has 76 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestHandleShell(t *testing.T) {
testCases := []struct {
desc string
cmd string
errMsg string
Function TestNewWithUsername
has 75 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestNewWithUsername(t *testing.T) {
tests := []struct {
desc string
command string
namespace string
Function TestNew
has 72 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestNew(t *testing.T) {
testCases := []struct {
desc string
executable *executable.Executable
env sshenv.Env
Function TestExecute
has 71 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestExecute(t *testing.T) {
setup(t)
url := testserver.StartSocketHttpServer(t, requests)
Function TestReceivePack
has 70 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestReceivePack(t *testing.T) {
for _, network := range []string{"unix", "tcp", "dns"} {
t.Run(fmt.Sprintf("via %s network", network), func(t *testing.T) {
gitalyAddress, testServer := testserver.StartGitalyServer(t, network)
t.Log(fmt.Sprintf("Server address: %s", gitalyAddress))
Function TestClients
has 69 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestClients(t *testing.T) {
testRoot := testhelper.PrepareTestRootDir(t)
testCases := []struct {
desc string
Function TestExecute
has 68 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestExecute(t *testing.T) {
requests := setup(t)
url := testserver.StartSocketHttpServer(t, requests)
Function TestUserKeyHandling
has 67 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestUserKeyHandling(t *testing.T) {
testRoot := testhelper.PrepareTestRootDir(t)
validRSAKey := rsaPublicKey(t)
Method mock_server
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
def mock_server(server)
server.mount_proc('/api/v4/internal/two_factor_manual_otp_check') do |req, res|
res.content_type = 'application/json'
res.status = 200
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method mock_server
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def mock_server(server)
server.mount_proc('/geo/proxy_git_ssh/info_refs_upload_pack') do |req, res|
res.content_type = 'application/json'
res.status = 200
Method mock_server
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def mock_server(server)
server.mount_proc('/geo/proxy_git_ssh/info_refs_receive_pack') do |req, res|
res.content_type = 'application/json'
res.status = 200
Function TestPrepareContext
has 60 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func TestPrepareContext(t *testing.T) {
tests := []struct {
name string
gc *GitalyCommand
env sshenv.Env