gitlabhq/gitlabhq

View on GitHub
app/finders/issuable_finder.rb

Summary

Maintainability
D
2 days
Test Coverage

Class IssuableFinder has 71 methods (exceeds 20 allowed). Consider refactoring.
Open

class IssuableFinder
  prepend FinderWithCrossProjectAccess
  include FinderMethods
  include CreatedAtFilter
  include Gitlab::Utils::StrongMemoize
Severity: Major
Found in app/finders/issuable_finder.rb - About 1 day to fix

    File issuable_finder.rb has 465 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class IssuableFinder
      prepend FinderWithCrossProjectAccess
      include FinderMethods
      include CreatedAtFilter
      include Gitlab::Utils::StrongMemoize
    Severity: Minor
    Found in app/finders/issuable_finder.rb - About 7 hrs to fix

      Method by_negation has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def by_negation(items)
          not_params = params[:not].dup
          # API endpoints send in `nil` values so we test if there are any non-nil
          return items unless not_params.present? && not_params.values.any?
      
      
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method use_cte_for_search? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def use_cte_for_search?
          strong_memoize(:use_cte_for_search) do
            next false unless search
            # Only simple unsorted & simple sorts can use CTE
            next false if params[:sort].present? && !params[:sort].in?(klass.simple_sorts.keys)
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method by_assignee has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def by_assignee(items)
          return items.assigned_to(assignees) if not_query? && assignees.any?
      
          if filter_by_no_assignee?
            items.unassigned
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method milestones has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def milestones
          return @milestones if defined?(@milestones)
      
          @milestones =
            if milestones?
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method by_milestone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def by_milestone(items)
          if milestones?
            if filter_by_no_milestone?
              items = items.left_joins_milestones.where(milestone_id: [-1, nil])
            elsif filter_by_any_milestone?
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method projects_public_or_visible_to_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def projects_public_or_visible_to_user
          projects =
            if group
              if params[:projects]
                find_group_projects.id_in(params[:projects])
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method by_my_reaction_emoji has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def by_my_reaction_emoji(items)
          if params[:my_reaction_emoji].present? && current_user
            items =
              if filter_by_no_reaction?
                items.not_awarded(current_user)
      Severity: Minor
      Found in app/finders/issuable_finder.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def by_closed_at(items)
          items = items.closed_after(params[:closed_after]) if params[:closed_after].present?
          items = items.closed_before(params[:closed_before]) if params[:closed_before].present?
      
          items
      Severity: Minor
      Found in app/finders/issuable_finder.rb and 4 other locations - About 15 mins to fix
      app/finders/concerns/created_at_filter.rb on lines 4..8
      app/finders/deployments_finder.rb on lines 56..60
      app/finders/issuable_finder.rb on lines 447..451
      app/finders/pipelines_finder.rb on lines 132..136

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def by_updated_at(items)
          items = items.updated_after(params[:updated_after]) if params[:updated_after].present?
          items = items.updated_before(params[:updated_before]) if params[:updated_before].present?
      
          items
      Severity: Minor
      Found in app/finders/issuable_finder.rb and 4 other locations - About 15 mins to fix
      app/finders/concerns/created_at_filter.rb on lines 4..8
      app/finders/deployments_finder.rb on lines 56..60
      app/finders/issuable_finder.rb on lines 454..458
      app/finders/pipelines_finder.rb on lines 132..136

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status