gitlabhq/gitlabhq

View on GitHub
app/models/ci/pipeline.rb

Summary

Maintainability
F
4 days
Test Coverage

Class Pipeline has 112 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Pipeline < ApplicationRecord
    extend Gitlab::Ci::Model
    include Ci::HasStatus
    include Importable
    include AfterCommitQueue
Severity: Major
Found in app/models/ci/pipeline.rb - About 2 days to fix

    File pipeline.rb has 778 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Ci
      class Pipeline < ApplicationRecord
        extend Gitlab::Ci::Model
        include Ci::HasStatus
        include Importable
    Severity: Major
    Found in app/models/ci/pipeline.rb - About 1 day to fix

      Method predefined_variables has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def predefined_variables
            Gitlab::Ci::Variables::Collection.new.tap do |variables|
              variables.append(key: 'CI_PIPELINE_IID', value: iid.to_s)
              variables.append(key: 'CI_PIPELINE_SOURCE', value: source.to_s)
      
      
      Severity: Minor
      Found in app/models/ci/pipeline.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lazy_ref_commit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def lazy_ref_commit
            return unless ::Gitlab::Ci::Features.pipeline_latest?
      
            BatchLoader.for(ref).batch do |refs, loader|
              next unless project.repository_exists?
      Severity: Minor
      Found in app/models/ci/pipeline.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method latest? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def latest?
            return false unless git_ref && commit.present?
      
            unless ::Gitlab::Ci::Features.pipeline_latest?
              return project.commit(git_ref) == commit
      Severity: Minor
      Found in app/models/ci/pipeline.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method predefined_commit_variables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def predefined_commit_variables
            Gitlab::Ci::Variables::Collection.new.tap do |variables|
              variables.append(key: 'CI_COMMIT_SHA', value: sha)
              variables.append(key: 'CI_COMMIT_SHORT_SHA', value: short_sha)
              variables.append(key: 'CI_COMMIT_BEFORE_SHA', value: before_sha)
      Severity: Minor
      Found in app/models/ci/pipeline.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def number_of_warnings
            BatchLoader.for(id).batch(default_value: 0) do |pipeline_ids, loader|
              ::Ci::Build.where(commit_id: pipeline_ids)
                .latest
                .failed_but_allowed
      Severity: Minor
      Found in app/models/ci/pipeline.rb and 1 other location - About 25 mins to fix
      app/models/ci/stage.rb on lines 119..126

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status