gitlabhq/gitlabhq

View on GitHub
app/models/member.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Member has 45 methods (exceeds 20 allowed). Consider refactoring.
Open

class Member < ApplicationRecord
  include AfterCommitQueue
  include Sortable
  include Importable
  include Expirable
Severity: Minor
Found in app/models/member.rb - About 6 hrs to fix

    File member.rb has 329 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Member < ApplicationRecord
      include AfterCommitQueue
      include Sortable
      include Importable
      include Expirable
    Severity: Minor
    Found in app/models/member.rb - About 3 hrs to fix

      Method retrieve_member has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def retrieve_member(source, user, existing_members)
            user = retrieve_user(user)
      
            if user.is_a?(User)
              if existing_members
      Severity: Minor
      Found in app/models/member.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status