Sign upLogin

gitlabhq/gitlabhq

View on GitHub
Star
app/models/merge_request.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class MergeRequest has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

class MergeRequest < ActiveRecord::Base
  include Issuable
  include InternalId

  belongs_to :target_project, foreign_key: :target_project_id, class_name: "Project"
Severity: Minor
Found in app/models/merge_request.rb - About 3 hrs to fix

    Method validate_branches has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_branches
    if target_project==source_project && target_branch == source_branch
      errors.add :branch_conflict, "You can not use same project/branch for source and target"
    end
    Severity: Minor
    Found in app/models/merge_request.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status