gitlabhq/gitlabhq

View on GitHub
app/models/merge_request_diff.rb

Summary

Maintainability
D
2 days
Test Coverage

Class MergeRequestDiff has 55 methods (exceeds 20 allowed). Consider refactoring.
Open

class MergeRequestDiff < ApplicationRecord
  include Sortable
  include Importable
  include ManualInverseAssociation
  include EachBatch
Severity: Major
Found in app/models/merge_request_diff.rb - About 7 hrs to fix

    File merge_request_diff.rb has 449 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MergeRequestDiff < ApplicationRecord
      include Sortable
      include Importable
      include ManualInverseAssociation
      include EachBatch
    Severity: Minor
    Found in app/models/merge_request_diff.rb - About 6 hrs to fix

      Method fetching_repository_diffs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def fetching_repository_diffs(diff_options)
          return unless block_given?
      
          diff_options ||= {}
      
      
      Severity: Minor
      Found in app/models/merge_request_diff.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ids_for_external_storage_migration has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.ids_for_external_storage_migration(limit:)
          # No point doing any work unless the feature is enabled
          return [] unless Gitlab.config.external_diffs.enabled
      
          case Gitlab.config.external_diffs.when
      Severity: Minor
      Found in app/models/merge_request_diff.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save_diffs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def save_diffs
          new_attributes = {}
      
          if compare.commits.size.zero?
            new_attributes[:state] = :empty
      Severity: Minor
      Found in app/models/merge_request_diff.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status