gitlabhq/gitlabhq

View on GitHub
app/models/milestone.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Milestone has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

class Milestone < ApplicationRecord
  # Represents a "No Milestone" state used for filtering Issues and Merge
  # Requests that have no milestone assigned.
  MilestoneStruct = Struct.new(:title, :name, :id)
  None = MilestoneStruct.new('No Milestone', 'No Milestone', 0)
Severity: Minor
Found in app/models/milestone.rb - About 3 hrs to fix

    Method milestone_format_reference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def milestone_format_reference(format = :iid)
        raise ArgumentError, _('Unknown format') unless [:iid, :name].include?(format)
    
        if group_milestone? && format == :iid
          raise ArgumentError, _('Cannot refer to a group milestone by an internal id!')
    Severity: Minor
    Found in app/models/milestone.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status