gitlabhq/gitlabhq

View on GitHub
app/models/note.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Note has 68 methods (exceeds 20 allowed). Consider refactoring.
Open

class Note < ApplicationRecord
  extend ActiveModel::Naming
  include Participable
  include Mentionable
  include Awardable
Severity: Major
Found in app/models/note.rb - About 1 day to fix

    File note.rb has 384 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Note < ApplicationRecord
      extend ActiveModel::Naming
      include Participable
      include Mentionable
      include Awardable
    Severity: Minor
    Found in app/models/note.rb - About 5 hrs to fix

      Method in_reply_to? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def in_reply_to?(other)
          case other
          when Note
            if part_of_discussion?
              in_reply_to?(other.noteable) && in_reply_to?(other.to_discussion)
      Severity: Minor
      Found in app/models/note.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method grouped_diff_discussions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def grouped_diff_discussions(diff_refs = nil)
            groups = {}
      
            diff_notes.fresh.discussions.each do |discussion|
              group_key =
      Severity: Minor
      Found in app/models/note.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status