gitlabhq/gitlabhq

View on GitHub
app/models/repository.rb

Summary

Maintainability
F
5 days
Test Coverage

Class Repository has 134 methods (exceeds 20 allowed). Consider refactoring.
Open

class Repository
  REF_MERGE_REQUEST = 'merge-requests'.freeze
  REF_KEEP_AROUND = 'keep-around'.freeze
  REF_ENVIRONMENTS = 'environments'.freeze
  MAX_DIVERGING_COUNT = 1000
Severity: Major
Found in app/models/repository.rb - About 2 days to fix

    File repository.rb has 805 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'securerandom'
    
    class Repository
      REF_MERGE_REQUEST = 'merge-requests'.freeze
      REF_KEEP_AROUND = 'keep-around'.freeze
    Severity: Major
    Found in app/models/repository.rb - About 1 day to fix

      Method keep_around has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def keep_around(*shas)
          shas.each do |sha|
            begin
              next unless sha.present? && commit_by(oid: sha)
      
      
      Severity: Minor
      Found in app/models/repository.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method blob_at has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def blob_at(sha, path)
          blob = Blob.decorate(raw_repository.blob_at(sha, path), project)
      
          # Don't attempt to return a special result if there is no blob at all
          return unless blob
      Severity: Minor
      Found in app/models/repository.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method next_branch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def next_branch(name, opts = {})
          branch_ids = self.branch_names.map do |n|
            next 1 if n == name
      
            result = n.match(/\A#{name}-([0-9]+)\z/)
      Severity: Minor
      Found in app/models/repository.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method merge_to_ref has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def merge_to_ref(user, source_sha, merge_request, target_ref, message)
      Severity: Minor
      Found in app/models/repository.rb - About 35 mins to fix

        Method find_commits_by_message has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def find_commits_by_message(query, ref = nil, path = nil, limit = 1000, offset = 0)
        Severity: Minor
        Found in app/models/repository.rb - About 35 mins to fix

          Method tree has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def tree(sha = :head, path = nil, recursive: false)
              if sha == :head
                return unless head_commit
          
                if path.nil?
          Severity: Minor
          Found in app/models/repository.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def revert(
              user, commit, branch_name, message,
              start_branch_name: nil, start_project: project)
          
              with_cache_hooks do
          Severity: Minor
          Found in app/models/repository.rb and 1 other location - About 15 mins to fix
          app/models/repository.rb on lines 888..900

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def cherry_pick(
              user, commit, branch_name, message,
              start_branch_name: nil, start_project: project)
          
              with_cache_hooks do
          Severity: Minor
          Found in app/models/repository.rb and 1 other location - About 15 mins to fix
          app/models/repository.rb on lines 872..884

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status