Sign upLogin

gitlabhq/gitlabhq

View on GitHub
Star
app/services/notification_service.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method reject_muted_users has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def reject_muted_users(users, project = nil)
    users = users.compact.uniq

    users.reject do |user|
      next user.notification.disabled? unless project
Severity: Minor
Found in app/services/notification_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new_note has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def new_note(note)
    # ignore wall messages
    return true unless note.noteable_type.present?

    # ignore gitlab service messages
Severity: Minor
Found in app/services/notification_service.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status