gitlabhq/gitlabhq

View on GitHub
app/services/system_note_service.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method change_branch_presence has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def change_branch_presence(noteable, project, author, branch_type, branch, presence)
Severity: Minor
Found in app/services/system_note_service.rb - About 45 mins to fix

    Method add_commits has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def add_commits(noteable, project, author, new_commits, existing_commits = [], oldrev = nil)
    Severity: Minor
    Found in app/services/system_note_service.rb - About 45 mins to fix

      Method change_branch has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def change_branch(noteable, project, author, branch_type, old_branch, new_branch)
      Severity: Minor
      Found in app/services/system_note_service.rb - About 45 mins to fix

        Method change_status has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def change_status(noteable, project, author, status, source = nil)
        Severity: Minor
        Found in app/services/system_note_service.rb - About 35 mins to fix

          Method change_time_spent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def change_time_spent(noteable, project, author)
              time_spent = noteable.time_spent
          
              if time_spent == :reset
                body = "removed time spent"
          Severity: Minor
          Found in app/services/system_note_service.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status