gitlabhq/gitlabhq

View on GitHub

Showing 1,499 of 2,147 total issues

Method bulk_insert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.bulk_insert(table, rows, return_ids: false, disable_quote: [])
      return if rows.empty?

      keys = rows.first.keys
      columns = keys.map { |key| connection.quote_column_name(key) }
Severity: Minor
Found in lib/gitlab/database.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method current_user has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def current_user(request, project)
        return unless has_basic_credentials?(request)

        login, password = user_name_and_password(request)
        auth_result = Gitlab::Auth.find_for_git_client(login, password, project: project, ip: request.ip)
Severity: Minor
Found in lib/gitlab/middleware/go.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loop_until has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def loop_until(timeout: nil, limit: 1_000_000)
      raise ArgumentError unless limit

      start = Time.now

Severity: Minor
Found in lib/gitlab/loop_helpers.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_authentication_abilities! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def check_authentication_abilities!(cmd)
      case cmd
      when *DOWNLOAD_COMMANDS
        unless authentication_abilities.include?(:download_code) || authentication_abilities.include?(:build_download_code)
          raise UnauthorizedError, ERROR_MESSAGES[:auth_download]
Severity: Minor
Found in lib/gitlab/git_access.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compare_source_branch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def compare_source_branch(target_branch_name, source_repository, source_branch_name, straight:)
        reachable_ref =
          if source_repository == self
            source_branch_name
          else
Severity: Minor
Found in lib/gitlab/git/repository.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method can_push_to_branch? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    request_cache def can_push_to_branch?(ref)
      return false unless can_access_git?
      return false unless project

      return false if !user.can?(:push_code, project) && !project.branch_allows_collaboration?(user, ref)
Severity: Minor
Found in lib/gitlab/user_access.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_count_commits_options has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def process_count_commits_options(options)
        if options[:from] || options[:to]
          ref =
            if options[:left_right] # Compare with merge-base for left-right
              "#{options[:from]}...#{options[:to]}"
Severity: Minor
Found in lib/gitlab/git/repository.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method user_merge_to_ref has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def user_merge_to_ref(user, source_sha, branch, target_ref, message, first_parent_ref)
Severity: Minor
Found in lib/gitlab/gitaly_client/operation_service.rb - About 45 mins to fix

    Method merge_to_ref has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def merge_to_ref(user, source_sha, branch, target_ref, message, first_parent_ref)
    Severity: Minor
    Found in lib/gitlab/git/repository.rb - About 45 mins to fix

      Method lfs_token_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def lfs_token_check(login, encoded_token, project)
              deploy_key_matches = login.match(/\Alfs\+deploy-key-(\d+)\z/)
      
              actor =
                if deploy_key_matches
      Severity: Minor
      Found in lib/gitlab/auth.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def find_file(name, revision)
              request = Gitaly::WikiFindFileRequest.new(
                repository: @gitaly_repo,
                name: encode_binary(name),
                revision: encode_binary(revision)
      Severity: Minor
      Found in lib/gitlab/gitaly_client/wiki_service.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_remote_mirror has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def update_remote_mirror(ref_name, only_branches_matching, ssh_key: nil, known_hosts: nil)
              req_enum = Enumerator.new do |y|
                first_request = Gitaly::UpdateRemoteMirrorRequest.new(
                  repository: @gitaly_repo,
                  ref_name: ref_name
      Severity: Minor
      Found in lib/gitlab/gitaly_client/remote_service.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_local_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def validate_local_request(
              normalized_hostname:,
              address_info:,
              allow_localhost:,
              allow_local_network:)
      Severity: Minor
      Found in lib/gitlab/url_blocker.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_concurrent_foreign_key has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def add_concurrent_foreign_key(source, target, column:, on_delete: :cascade, name: nil)
              # Transactions would result in ALTER TABLE locks being held for the
              # duration of the transaction, defeating the purpose of this method.
              if transaction_open?
                raise 'add_concurrent_foreign_key can not be run inside a transaction'
      Severity: Minor
      Found in lib/gitlab/database/migration_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method store_in_cache_if_needed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def store_in_cache_if_needed
                return delete_from_cache unless commit
                return unless sha
                return unless ref
      
      
      Severity: Minor
      Found in lib/gitlab/cache/ci/project_pipeline_status.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lazy_page_iterator has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def lazy_page_iterator(starting_page: 1, page_limit: nil, per_page: PER_PAGE)
              Enumerator.new do |y|
                page = starting_page
                page_limit = (starting_page - 1) + page_limit if page_limit
      
      
      Severity: Minor
      Found in lib/gitlab/gitlab_import/client.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method list_key_ids has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def list_key_ids
            logger.info('Listing all key IDs')
      
            [].tap do |a|
              open_authorized_keys_file('r') do |f|
      Severity: Minor
      Found in lib/gitlab/authorized_keys.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method in_lock has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def in_lock(key, ttl: 1.minute, retries: 10, sleep_sec: 0.01.seconds)
            raise ArgumentError, 'Key needs to be specified' unless key
      
            lease = Gitlab::ExclusiveLease.new(key, timeout: ttl)
      
      
      Severity: Minor
      Found in lib/gitlab/exclusive_lease_helpers.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method diff has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def diff(from, to, options = {})
              from_id = case from
                        when NilClass
                          Gitlab::Git::EMPTY_TREE_ID
                        else
      Severity: Minor
      Found in lib/gitlab/gitaly_client/commit_service.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method format_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def format_response(response)
                response[:text] = format(response[:text]) if response.key?(:text)
      
                if response.key?(:attachments)
                  response[:attachments].each do |attachment|
      Severity: Minor
      Found in lib/gitlab/slash_commands/presenters/base.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language