gitlabhq/gitlabhq

View on GitHub

Showing 1,679 of 2,388 total issues

Method change_branch_presence has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def change_branch_presence(noteable, project, author, branch_type, branch, presence)
Severity: Minor
Found in app/services/system_note_service.rb - About 45 mins to fix

    Method execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def execute
          remove_unallowed_params
          set_visibility_level
    
          @group = Group.new(params)
    Severity: Minor
    Found in app/services/groups/create_service.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method change_branch has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def change_branch(noteable, project, author, branch_type, old_branch, new_branch)
    Severity: Minor
    Found in app/services/system_note_service.rb - About 45 mins to fix

      Method remaining_days_in_words has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def remaining_days_in_words(due_date, start_date = nil)
          if due_date&.past?
            content_tag(:strong, _('Past due'))
          elsif due_date&.today?
            content_tag(:strong, _('Today'))
      Severity: Minor
      Found in app/serializers/entity_date_helper.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method test_wait_with_counter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

                def test_wait_with_counter
                  Timecop.freeze(time_start) do
                    subject.repeat_until(max_duration: 3, raise_on_failure: false, retry_on_exception: true) do
                      @loop_counter += 1
                      Timecop.travel(time_start + @loop_counter)
      Severity: Minor
      Found in qa/spec/support/repeater_spec.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method data_to_insert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def data_to_insert(query)
              data = { 'jira_tracker_data' => [], 'issue_tracker_data' => [] }
              select_all(query).each do |service|
                begin
                  properties = JSON.parse(service['properties'])
      Severity: Minor
      Found in lib/gitlab/background_migration/migrate_issue_trackers_sensitive_data.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def call
              return doc if context[:autolink] == false
      
              doc.xpath(TEXT_QUERY).each do |node|
                content = node.to_html
      Severity: Minor
      Found in lib/banzai/filter/autolink_filter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(path, filename: nil, content_type: "application/octet-stream", sha256: nil, remote_id: nil, size: nil)
          if path.present?
            raise InvalidPathError, "#{path} file does not exist" unless ::File.exist?(path)
      
            @tempfile = File.new(path, 'rb')
      Severity: Minor
      Found in lib/uploaded_file.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method remove_non_heading_ids has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def remove_non_heading_ids
                lambda do |env|
                  node = env[:node]
      
                  return unless SECTION_HEADINGS.any?(node.name)
      Severity: Minor
      Found in lib/banzai/filter/ascii_doc_sanitization_filter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def run(args)
              unless args.include?('--')
                index = args.index { |opt| opt.include?('features') }
      
                args.insert(index, '--') if index
      Severity: Minor
      Found in qa/qa/specs/parallel_runner.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method remove_non_footnote_ids has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def remove_non_footnote_ids
                lambda do |env|
                  node = env[:node]
      
                  return unless (pattern = FOOTNOTE_LINK_ID_PATTERNS[node.name.to_sym])
      Severity: Minor
      Found in lib/banzai/filter/ascii_doc_sanitization_filter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method expand_attributes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def expand_attributes(klass, attributes)
              expanded = attributes.flat_map do |attribute|
                attr_config = klass.encrypted_attributes[attribute]
                crypt_column_name = attr_config&.fetch(:attribute)
      
      
      Severity: Minor
      Found in lib/gitlab/background_migration/encrypt_columns.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def do_run
              raise ArgumentError, "Please provide GITLAB_USERNAME" unless ENV['GITLAB_USERNAME']
              raise ArgumentError, "Please provide GITLAB_PASSWORD" unless ENV['GITLAB_PASSWORD']
              raise ArgumentError, "Please provide GITLAB_ADDRESS" unless ENV['GITLAB_ADDRESS']
      
      
      Severity: Minor
      Found in qa/qa/tools/revoke_all_personal_access_tokens.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_uri_types has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def load_uri_types
              return unless linkable_attributes.present?
              return unless linkable_files?
              return {} unless repository
      
      
      Severity: Minor
      Found in lib/banzai/filter/repository_link_filter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_link_to_upload_attr has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_link_to_upload_attr(html_attr)
              return unless html_attr.value.start_with?('/uploads/')
      
              path_parts = [unescape_and_scrub_uri(html_attr.value)]
      
      
      Severity: Minor
      Found in lib/banzai/filter/upload_link_filter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sign_in_using_credentials has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def sign_in_using_credentials(user: nil, skip_page_validation: false)
                # Don't try to log-in if we're already logged-in
                return if Page::Main::Menu.perform(&:signed_in?)
      
                using_wait_time 0 do
      Severity: Minor
      Found in qa/qa/page/main/login.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method serialize_include_definition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def serialize_include_definition(definition)
              raise ArgumentError, 'definition needs to be Hash' unless definition.is_a?(Hash)
              raise ArgumentError, 'definition needs to have exactly one Hash element' unless definition.one?
      
              key = definition.first.first
      Severity: Minor
      Found in lib/gitlab/import_export/fast_hash_serializer.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ensure_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def ensure_hash(ambiguous_param)
              case ambiguous_param
              when String
                if ambiguous_param.present?
                  ensure_hash(JSON.parse(ambiguous_param))
      Severity: Minor
      Found in lib/gitlab/graphql/variables.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method groups has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def groups(highlight: true)
            prev_sha = nil
            groups = []
            current_group = nil
      
      
      Severity: Minor
      Found in lib/gitlab/blame.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method aggregate_rblineprof has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def aggregate_rblineprof(lineprof_stats)
              samples = []
      
              lineprof_stats.each do |(file, stats)|
                source_lines = File.read(file).each_line.to_a
      Severity: Minor
      Found in lib/gitlab/sherlock/line_profiler.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language