gitlabhq/gitlabhq

View on GitHub
lib/api/merge_requests.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File merge_requests.rb has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module API
  class MergeRequests < Grape::API::Instance
    include PaginationParams

    CONTEXT_COMMITS_POST_LIMIT = 20
Severity: Minor
Found in lib/api/merge_requests.rb - About 6 hrs to fix

    Method authorize_push_to_merge_request! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def authorize_push_to_merge_request!(merge_request)
            forbidden!('Source branch does not exist') unless
              merge_request.source_branch_exists?
    
            user_access = Gitlab::UserAccess.new(
    Severity: Minor
    Found in lib/api/merge_requests.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status