gitlabhq/gitlabhq

View on GitHub
lib/backup/manager.rb

Summary

Maintainability
C
1 day
Test Coverage

Method unpack has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def unpack
      Dir.chdir(backup_path) do
        # check for existing backups in the backup dir
        if backup_file_list.empty?
          progress.puts "No backups found in #{backup_path}"
Severity: Minor
Found in lib/backup/manager.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove_old has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def remove_old
      # delete backups
      progress.print "Deleting old backups ... "
      keep_time = Gitlab.config.backup.keep_time.to_i

Severity: Minor
Found in lib/backup/manager.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Manager has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Manager
    ARCHIVES_TO_BACKUP = %w[uploads builds artifacts pages lfs registry].freeze
    FOLDERS_TO_BACKUP = %w[repositories db].freeze
    FILE_NAME_SUFFIX = '_gitlab_backup.tar'.freeze

Severity: Minor
Found in lib/backup/manager.rb - About 2 hrs to fix

    Method unpack has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def unpack
          Dir.chdir(backup_path) do
            # check for existing backups in the backup dir
            if backup_file_list.empty?
              progress.puts "No backups found in #{backup_path}"
    Severity: Minor
    Found in lib/backup/manager.rb - About 1 hr to fix

      Method cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def cleanup
            progress.print "Deleting tmp directories ... "
      
            backup_contents.each do |dir|
              next unless File.exist?(File.join(backup_path, dir))
      Severity: Minor
      Found in lib/backup/manager.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status