gitlabhq/gitlabhq

View on GitHub
lib/gitlab/ci/trace/chunked_io.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class ChunkedIO has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

      class ChunkedIO
        CHUNK_SIZE = ::Ci::BuildTraceChunk::CHUNK_SIZE

        FailedToGetChunkError = Class.new(StandardError)

Severity: Minor
Found in lib/gitlab/ci/trace/chunked_io.rb - About 3 hrs to fix

    Method readline has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def readline
              out = []
    
              until eof?
                data = chunk_slice_from_offset
    Severity: Minor
    Found in lib/gitlab/ci/trace/chunked_io.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def read(length = nil, outbuf = nil)
              out = []
    
              length ||= size - tell
    
    
    Severity: Minor
    Found in lib/gitlab/ci/trace/chunked_io.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method chunk_slice_from_offset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def chunk_slice_from_offset
              unless in_range?
                current_chunk.tap do |chunk|
                  raise FailedToGetChunkError unless chunk
    
    
    Severity: Minor
    Found in lib/gitlab/ci/trace/chunked_io.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status