gitlabhq/gitlabhq

View on GitHub
lib/gitlab/git/commit.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Commit has 53 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Commit
      include Gitlab::EncodingHelper
      prepend Gitlab::Git::RuggedImpl::Commit
      extend Gitlab::Git::WrapsGitalyErrors

Severity: Major
Found in lib/gitlab/git/commit.rb - About 7 hrs to fix

    File commit.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Gitlab
      module Git
        class Commit
          include Gitlab::EncodingHelper
          prepend Gitlab::Git::RuggedImpl::Commit
    Severity: Minor
    Found in lib/gitlab/git/commit.rb - About 2 hrs to fix

      Method find has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def find(repo, commit_id = "HEAD")
                # Already a commit?
                return commit_id if commit_id.is_a?(Gitlab::Git::Commit)
      
                # Some weird thing?
      Severity: Minor
      Found in lib/gitlab/git/commit.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status