gitlabhq/gitlabhq

View on GitHub
lib/gitlab/git/repository.rb

Summary

Maintainability
F
4 days
Test Coverage

Class Repository has 120 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Repository
      include Gitlab::Git::RepositoryMirroring
      include Gitlab::Git::WrapsGitalyErrors
      include Gitlab::EncodingHelper
      include Gitlab::Utils::StrongMemoize
Severity: Major
Found in lib/gitlab/git/repository.rb - About 2 days to fix

    File repository.rb has 759 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'tempfile'
    require 'forwardable'
    require "rubygems/package"
    
    module Gitlab
    Severity: Major
    Found in lib/gitlab/git/repository.rb - About 1 day to fix

      Method compare_source_branch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def compare_source_branch(target_branch_name, source_repository, source_branch_name, straight:)
              reachable_ref =
                if source_repository == self
                  source_branch_name
                else
      Severity: Minor
      Found in lib/gitlab/git/repository.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_count_commits_options has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_count_commits_options(options)
              if options[:from] || options[:to]
                ref =
                  if options[:left_right] # Compare with merge-base for left-right
                    "#{options[:from]}...#{options[:to]}"
      Severity: Minor
      Found in lib/gitlab/git/repository.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_commits_by_message has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def find_commits_by_message(query, ref, path, limit, offset)
      Severity: Minor
      Found in lib/gitlab/git/repository.rb - About 35 mins to fix

        Method merge_to_ref has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def merge_to_ref(user, source_sha, branch, target_ref, message)
        Severity: Minor
        Found in lib/gitlab/git/repository.rb - About 35 mins to fix

          Method merge has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def merge(user, source_sha, target_branch, message, &block)
          Severity: Minor
          Found in lib/gitlab/git/repository.rb - About 35 mins to fix

            Method refs_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def refs_hash
                    return @refs_hash if @refs_hash
            
                    @refs_hash = Hash.new { |h, k| h[k] = [] }
            
            
            Severity: Minor
            Found in lib/gitlab/git/repository.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def cherry_pick(user:, commit:, branch_name:, message:, start_branch_name:, start_repository:)
                    args = {
                      user: user,
                      commit: commit,
                      branch_name: branch_name,
            Severity: Minor
            Found in lib/gitlab/git/repository.rb and 1 other location - About 20 mins to fix
            lib/gitlab/git/repository.rb on lines 585..596

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def revert(user:, commit:, branch_name:, message:, start_branch_name:, start_repository:)
                    args = {
                      user: user,
                      commit: commit,
                      branch_name: branch_name,
            Severity: Minor
            Found in lib/gitlab/git/repository.rb and 1 other location - About 20 mins to fix
            lib/gitlab/git/repository.rb on lines 600..611

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status