gitlabhq/gitlabhq

View on GitHub
lib/gitlab/gitaly_client/operation_service.rb

Summary

Maintainability
D
2 days
Test Coverage

File operation_service.rb has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Gitlab
  module GitalyClient
    class OperationService
      include Gitlab::EncodingHelper

Severity: Minor
Found in lib/gitlab/gitaly_client/operation_service.rb - About 5 hrs to fix

    Class OperationService has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class OperationService
          include Gitlab::EncodingHelper
    
          MAX_MSG_SIZE = 128.kilobytes.freeze
    
    
    Severity: Minor
    Found in lib/gitlab/gitaly_client/operation_service.rb - About 2 hrs to fix

      Method rebase has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def rebase(user, rebase_id, branch:, branch_sha:, remote_repository:, remote_branch:, push_options: [])
              request_enum = QueueEnumerator.new
              rebase_sha = nil
      
              response_enum = GitalyClient.call(
      Severity: Minor
      Found in lib/gitlab/gitaly_client/operation_service.rb - About 1 hr to fix

        Method user_commit_files_request_header has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                user, branch_name, commit_message, actions, author_email, author_name,
                start_branch_name, start_repository, force, start_sha)
        Severity: Major
        Found in lib/gitlab/gitaly_client/operation_service.rb - About 1 hr to fix

          Method user_commit_files has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  user, branch_name, commit_message, actions, author_email, author_name,
                  start_branch_name, start_repository, force = false, start_sha = nil)
          Severity: Major
          Found in lib/gitlab/gitaly_client/operation_service.rb - About 1 hr to fix

            Method user_commit_files has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def user_commit_files(
                    user, branch_name, commit_message, actions, author_email, author_name,
                    start_branch_name, start_repository, force = false, start_sha = nil)
                    req_enum = Enumerator.new do |y|
                      header = user_commit_files_request_header(user, branch_name,
            Severity: Minor
            Found in lib/gitlab/gitaly_client/operation_service.rb - About 1 hr to fix

              Method user_merge_branch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def user_merge_branch(user, source_sha, target_branch, message)
                      request_enum = QueueEnumerator.new
                      response_enum = GitalyClient.call(
                        @repository.storage,
                        :operation_service,
              Severity: Minor
              Found in lib/gitlab/gitaly_client/operation_service.rb - About 1 hr to fix

                Method user_merge_to_ref has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def user_merge_to_ref(user, source_sha, branch, target_ref, message, first_parent_ref)
                Severity: Minor
                Found in lib/gitlab/gitaly_client/operation_service.rb - About 45 mins to fix

                  Method user_squash has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def user_squash(user, squash_id, start_sha, end_sha, author, message)
                  Severity: Minor
                  Found in lib/gitlab/gitaly_client/operation_service.rb - About 45 mins to fix

                    Method user_create_branch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def user_create_branch(branch_name, user, start_point)
                            request = Gitaly::UserCreateBranchRequest.new(
                              repository: @gitaly_repo,
                              branch_name: encode_binary(branch_name),
                              user: Gitlab::Git::User.from_gitlab(user).to_gitaly,
                    Severity: Minor
                    Found in lib/gitlab/gitaly_client/operation_service.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def rm_tag(tag_name, user)
                            request = Gitaly::UserDeleteTagRequest.new(
                              repository: @gitaly_repo,
                              tag_name: encode_binary(tag_name),
                              user: Gitlab::Git::User.from_gitlab(user).to_gitaly
                    Severity: Minor
                    Found in lib/gitlab/gitaly_client/operation_service.rb and 1 other location - About 45 mins to fix
                    lib/gitlab/gitaly_client/operation_service.rb on lines 90..101

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 41.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def user_delete_branch(branch_name, user)
                            request = Gitaly::UserDeleteBranchRequest.new(
                              repository: @gitaly_repo,
                              branch_name: encode_binary(branch_name),
                              user: Gitlab::Git::User.from_gitlab(user).to_gitaly
                    Severity: Minor
                    Found in lib/gitlab/gitaly_client/operation_service.rb and 1 other location - About 45 mins to fix
                    lib/gitlab/gitaly_client/operation_service.rb on lines 15..25

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 41.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status