gitlabhq/gitlabhq

View on GitHub
lib/gitlab/google_code_import/importer.rb

Summary

Maintainability
D
1 day
Test Coverage

File importer.rb has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Gitlab
  module GoogleCodeImport
    class Importer
      attr_reader :project, :repo, :closed_statuses

Severity: Minor
Found in lib/gitlab/google_code_import/importer.rb - About 2 hrs to fix

    Method format_updates has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

          def format_updates(raw_updates)
            updates = []
    
            if raw_updates.key?("status")
              updates << "*Status: #{raw_updates["status"]}*"
    Severity: Minor
    Found in lib/gitlab/google_code_import/importer.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import_issues has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def import_issues
            return unless repo.issues
    
            while raw_issue = repo.issues.shift
              author  = user_map[raw_issue["author"]["name"]]
    Severity: Minor
    Found in lib/gitlab/google_code_import/importer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method format_updates has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def format_updates(raw_updates)
            updates = []
    
            if raw_updates.key?("status")
              updates << "*Status: #{raw_updates["status"]}*"
    Severity: Minor
    Found in lib/gitlab/google_code_import/importer.rb - About 1 hr to fix

      Method import_issues has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def import_issues
              return unless repo.issues
      
              while raw_issue = repo.issues.shift
                author  = user_map[raw_issue["author"]["name"]]
      Severity: Minor
      Found in lib/gitlab/google_code_import/importer.rb - About 1 hr to fix

        Method import_issue_comments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

              def import_issue_comments(issue, comments)
                Note.transaction do
                  while raw_comment = comments.shift
                    next if raw_comment.key?("deletedBy")
        
        
        Severity: Minor
        Found in lib/gitlab/google_code_import/importer.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method import_issue_comments has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def import_issue_comments(issue, comments)
                Note.transaction do
                  while raw_comment = comments.shift
                    next if raw_comment.key?("deletedBy")
        
        
        Severity: Minor
        Found in lib/gitlab/google_code_import/importer.rb - About 1 hr to fix

          Method format_issue_comment_body has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def format_issue_comment_body(id, author, date, content, updates, attachments)
          Severity: Minor
          Found in lib/gitlab/google_code_import/importer.rb - About 45 mins to fix

            Method format_attachments has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def format_attachments(issue_id, comment_id, raw_attachments)
                    return [] unless raw_attachments
            
                    raw_attachments.map do |attachment|
                      next if attachment["isDeleted"]
            Severity: Minor
            Found in lib/gitlab/google_code_import/importer.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def escape_for_markdown(str)
                    # No headings and lists
                    str = str.gsub(/^#/, "\\#")
                    str = str.gsub(/^-/, "\\-")
            
            
            Severity: Minor
            Found in lib/gitlab/google_code_import/importer.rb and 1 other location - About 20 mins to fix
            lib/gitlab/fogbugz_import/importer.rb on lines 206..212

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status