Sign upLogin

gitlabhq/grit

View on GitHub
Star
lib/grit/repo.rb

Summary

Maintainability
F
3 days
Test Coverage

Class Repo has 66 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Repo
    include POSIX::Spawn

    DAEMON_EXPORT_FILE = 'git-daemon-export-ok'
    BATCH_PARSERS      = {
Severity: Major
Found in lib/grit/repo.rb - About 1 day to fix

    File repo.rb has 453 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Grit
  class Repo
    include POSIX::Spawn

    DAEMON_EXPORT_FILE = 'git-daemon-export-ok'
    Severity: Minor
    Found in lib/grit/repo.rb - About 6 hrs to fix

      Method advanced_grep has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          def advanced_grep(searchtext, contextlines = 3, branch = 'master')

      # If there's not an even number of quote marks, get rid of them all
      searchtext = searchtext.gsub('"', '') if searchtext.count('"') % 2 == 1
      Severity: Minor
      Found in lib/grit/repo.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method advanced_grep has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def advanced_grep(searchtext, contextlines = 3, branch = 'master')

      # If there's not an even number of quote marks, get rid of them all
      searchtext = searchtext.gsub('"', '') if searchtext.count('"') % 2 == 1
      Severity: Major
      Found in lib/grit/repo.rb - About 2 hrs to fix

        Method grep has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def grep(searchtext, contextlines = 3, branch = 'master')
      context_arg = '-C ' + contextlines.to_s
      result = git.native(:grep, {}, '-n', '-E', '-i', '-z', '--heading', '--break', context_arg, searchtext, branch).encode('UTF-8', invalid: :replace, undef: :replace, replace: '')
      greps = []
      filematches = result.split("\n\n")
        Severity: Minor
        Found in lib/grit/repo.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method grep has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def grep(searchtext, contextlines = 3, branch = 'master')
      context_arg = '-C ' + contextlines.to_s
      result = git.native(:grep, {}, '-n', '-E', '-i', '-z', '--heading', '--break', context_arg, searchtext, branch).encode('UTF-8', invalid: :replace, undef: :replace, replace: '')
      greps = []
      filematches = result.split("\n\n")
        Severity: Minor
        Found in lib/grit/repo.rb - About 1 hr to fix

          Method archive_to_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def archive_to_file(treeish = 'master', prefix = nil, filename = 'archive.tar.gz', format = nil, compress_cmd = %W(gzip))
          Severity: Minor
          Found in lib/grit/repo.rb - About 35 mins to fix

            Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize(path, options = {})
      epath = File.expand_path(path)

      if File.exist?(File.join(epath, '.git'))
        self.working_dir = epath
            Severity: Minor
            Found in lib/grit/repo.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      lines.each_with_index do |line, j|
            line.chomp!
            number, text = line.split("\0", 2)
            if j == 0
              startline = number.to_i
            Severity: Minor
            Found in lib/grit/repo.rb and 1 other location - About 15 mins to fix
            lib/grit/repo.rb on lines 790..796

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      lines.each_with_index do |line, j|
            line.chomp!
            number, text = line.split("\0", 2)
            if j == 0
              startline = number.to_i
            Severity: Minor
            Found in lib/grit/repo.rb and 1 other location - About 15 mins to fix
            lib/grit/repo.rb on lines 709..715

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status