gjerokrsteski/pimf-framework

View on GitHub
core/Pimf/Controller/Base.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function render()
    {
        if (Sapi::isCli() && Config::get('environment') == 'production') {
            $suffix = 'CliAction';
            $action = $this->request->fromCli()->get('action', 'index');
Severity: Minor
Found in core/Pimf/Controller/Base.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function render()
    {
        if (Sapi::isCli() && Config::get('environment') == 'production') {
            $suffix = 'CliAction';
            $action = $this->request->fromCli()->get('action', 'index');
Severity: Minor
Found in core/Pimf/Controller/Base.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Request $request,
            Response $response = null,
            Logger $logger,
            $em,
            Router $router,
    Severity: Minor
    Found in core/Pimf/Controller/Base.php - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status