Sign upLogin

gjerokrsteski/reactphp-pimf

View on GitHub
Star
app/Articles/Application/Dispatcher.php

Summary

Maintainability
A
0 mins
Test Coverage

Method __invoke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function __invoke(ReactiveRequest $request, ReactiveResponse $response)
    {
        $this->request = $request;
        $this->response = $response;
Severity: Minor
Found in app/Articles/Application/Dispatcher.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Wontfix

                    return $routeTo(new WriteAllowedRequestMethods($this->response));
    Severity: Major
    Found in app/Articles/Application/Dispatcher.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Wontfix

                      return $routeTo(new UpdateExistingArticle($this->entityManager, $this->request, $this->response));
      Severity: Major
      Found in app/Articles/Application/Dispatcher.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Wontfix

                        return $routeTo(new DeleteExistingArticle($this->entityManager, $this->request, $this->response));
        Severity: Major
        Found in app/Articles/Application/Dispatcher.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Wontfix

                          return $routeTo(new ListApiUsageOptions($this->response));
          Severity: Major
          Found in app/Articles/Application/Dispatcher.php - About 30 mins to fix

            Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
            Wontfix

                            Json::encode([
                    'list api usage options' => [
                        'url' => '/articles',
                        'method' => 'OPTIONS',
                    ],
            Severity: Minor
            Found in app/Articles/Application/Dispatcher.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\Pimf\Uri' in method '__invoke'.
            Wontfix

                    Uri::setup($this->request->getPath(), $this->request->getPath());
            Severity: Minor
            Found in app/Articles/Application/Dispatcher.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            There are no issues that match your filters.

            Category
            Status