gjerokrsteski/reactphp-pimf

View on GitHub
app/Articles/Service/CreateNewArticle.php

Summary

Maintainability
A
0 mins
Test Coverage

Method __invoke has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function __invoke($requestBody = '')
    {
        $this->request->on('data', function ($requestBody) {

            $route = new Route('/articles/:id');
Severity: Minor
Found in app/Articles/Service/CreateNewArticle.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Wontfix

                return $this->response->end();
    Severity: Major
    Found in app/Articles/Service/CreateNewArticle.php - About 30 mins to fix

      Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
      Wontfix

                      return $this->response->end(Json::encode(compact('newId')));

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      There are no issues that match your filters.

      Category
      Status