gjerokrsteski/reactphp-pimf

View on GitHub
app/Articles/Service/ListApiUsageOptions.php

Summary

Maintainability
A
0 mins
Test Coverage

Method __invoke has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function __invoke($requestBody = '')
    {
        $this->response->writeHead(200, ['Content-Type' => 'application/json; charset=utf-8']);

        return $this->response->end(Json::encode([
Severity: Minor
Found in app/Articles/Service/ListApiUsageOptions.php - About 1 hr to fix

    Avoid unused parameters such as '$requestBody'.
    Wontfix

        public function __invoke($requestBody = '')

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
    Wontfix

            return $this->response->end(Json::encode([
    
                'create new article' => [
                    'url' => '/articles',
                    'method' => 'POST',

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status