gjerokrsteski/reactphp-pimf

Identical code found in 1 other location (mass = 32)
Open

final class CreateNewArticle
{
    /**
     * @var EntityManager
     */
app/Articles/Service/UpdateExistingArticle.php on lines 12..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical code found in 1 other location (mass = 32)
Open

final class UpdateExistingArticle
{
    /**
     * @var EntityManager
     */
app/Articles/Service/CreateNewArticle.php on lines 13..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = (int)$this->pdo->lastInsertId();
Severity: Minor
Found in app/Articles/DataMapper/Article.php by phpmd

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:


  class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }


Source: http://phpmd.org/rules/naming.txt

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    protected $id;
Severity: Minor
Found in app/Articles/Model/Article.php by phpmd

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:


  class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }


Source: http://phpmd.org/rules/naming.txt

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $requestData->get('id');

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:


  class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }


Source: http://phpmd.org/rules/naming.txt

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $query->get('id');

Since: PHPMD 0.2

Detects when a field, local, or parameter has a very short name.

Example:


  class Something {
      private $q = 15; // VIOLATION - Field
      public static function main( array $as ) { // VIOLATION - Formal
          $r = 20 + $this->q; // VIOLATION - Local
          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
              $r += $this->q;
          }
      }
  }


Source: http://phpmd.org/rules/naming.txt

Avoid using static access to class '\Pimf\Uri' in method '__invoke'.
Open

        Uri::setup($this->request->getPath(), $this->request->getPath());

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:


  class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }


Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
Open

                Json::encode([
                    'list api usage options' => [
                        'url' => '/articles',
                        'method' => 'OPTIONS',
                    ],

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:


  class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }


Source: http://phpmd.org/rules/cleancode.txt

Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
Open

                return $this->response->end(Json::encode(compact('newId')));

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:


  class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }


Source: http://phpmd.org/rules/cleancode.txt

Avoid unused parameters such as '$requestBody'.
Open

    public function __invoke($requestBody = '')

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:


  class Foo
  {
      private function bar($howdy)
      {
          // $howdy is not used
      }
  }


Source: http://phpmd.org/rules/unusedcode.txt

Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
Open

        return $this->response->end(Json::encode($article->toArray()));

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:


  class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }


Source: http://phpmd.org/rules/cleancode.txt

Avoid unused parameters such as '$requestBody'.
Open

    public function __invoke($requestBody = '')

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:


  class Foo
  {
      private function bar($howdy)
      {
          // $howdy is not used
      }
  }


Source: http://phpmd.org/rules/unusedcode.txt

Avoid using static access to class '\Pimf\Util\Json' in method '__invoke'.
Open

        return $this->response->end(Json::encode([

            'create new article' => [
                'url' => '/articles',
                'method' => 'POST',

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:


  class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }


Source: http://phpmd.org/rules/cleancode.txt

Avoid unused parameters such as '$requestBody'.
Open

    public function __invoke($requestBody = '')

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:


  class Foo
  {
      private function bar($howdy)
      {
          // $howdy is not used
      }
  }


Source: http://phpmd.org/rules/unusedcode.txt

Severity
Category
Status