Sign upLogin

gramps-graphql/gramps

View on GitHub
Star

Showing 5 of 5 total issues

Function preparei18nextResources has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const preparei18nextResources = dataSources => {
  const dataSourcesWithLocales = dataSources.filter(
    dataSource => dataSource.locales,
  );
Severity: Minor
Found in packages/gramps/src/helpers/preparei18nextResources.js - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      patch(endpoint, body = {}, options = {}) {
    const mutationOptions = this.getMutationOptions(body, options);

    return this.mutation(endpoint, 'PATCH', mutationOptions);
  }
    Severity: Major
    Found in packages/rest-helpers/src/GraphQLConnector.js and 3 other locations - About 55 mins to fix
    packages/rest-helpers/src/GraphQLConnector.js on lines 240..244
    packages/rest-helpers/src/GraphQLConnector.js on lines 253..257
    packages/rest-helpers/src/GraphQLConnector.js on lines 279..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      post(endpoint, body = {}, options = {}) {
    const mutationOptions = this.getMutationOptions(body, options);

    return this.mutation(endpoint, 'POST', mutationOptions);
  }
    Severity: Major
    Found in packages/rest-helpers/src/GraphQLConnector.js and 3 other locations - About 55 mins to fix
    packages/rest-helpers/src/GraphQLConnector.js on lines 253..257
    packages/rest-helpers/src/GraphQLConnector.js on lines 266..270
    packages/rest-helpers/src/GraphQLConnector.js on lines 279..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      put(endpoint, body = {}, options = {}) {
    const mutationOptions = this.getMutationOptions(body, options);

    return this.mutation(endpoint, 'PUT', mutationOptions);
  }
    Severity: Major
    Found in packages/rest-helpers/src/GraphQLConnector.js and 3 other locations - About 55 mins to fix
    packages/rest-helpers/src/GraphQLConnector.js on lines 240..244
    packages/rest-helpers/src/GraphQLConnector.js on lines 266..270
    packages/rest-helpers/src/GraphQLConnector.js on lines 279..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      delete(endpoint, options = {}, body = {}) {
    const mutationOptions = this.getMutationOptions(body, options);

    return this.mutation(endpoint, 'DELETE', mutationOptions);
  }
    Severity: Major
    Found in packages/rest-helpers/src/GraphQLConnector.js and 3 other locations - About 55 mins to fix
    packages/rest-helpers/src/GraphQLConnector.js on lines 240..244
    packages/rest-helpers/src/GraphQLConnector.js on lines 253..257
    packages/rest-helpers/src/GraphQLConnector.js on lines 266..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language