gund/eslint-plugin-deprecation

View on GitHub

Showing 10 of 10 total issues

Function isDeclaration has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

function isDeclaration(
  id: TSESTree.Identifier | TSESTree.JSXIdentifier,
  context: TSESLint.RuleContext<MessageIds, Options>,
) {
  const parent = getParent(context);
Severity: Minor
Found in src/rules/deprecation.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isDeclaration has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function isDeclaration(
  id: TSESTree.Identifier | TSESTree.JSXIdentifier,
  context: TSESLint.RuleContext<MessageIds, Options>,
) {
  const parent = getParent(context);
Severity: Major
Found in src/rules/deprecation.ts - About 2 hrs to fix

    File deprecation.ts has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * This program is free software; you can redistribute it and/or
     * modify it under the terms of the GNU Lesser General Public
     * License as published by the Free Software Foundation; either
     * version 3 of the License, or (at your option) any later version.
    Severity: Minor
    Found in src/rules/deprecation.ts - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function isPropertyAssignment(node: ts.Node): node is ts.PropertyAssignment {
        return node.kind === ts.SyntaxKind.PropertyAssignment;
      }
      Severity: Minor
      Found in src/rules/deprecation.ts and 1 other location - About 55 mins to fix
      src/rules/deprecation.ts on lines 321..325

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function isShorthandPropertyAssignment(
        node: ts.Node,
      ): node is ts.ShorthandPropertyAssignment {
        return node.kind === ts.SyntaxKind.ShorthandPropertyAssignment;
      }
      Severity: Minor
      Found in src/rules/deprecation.ts and 1 other location - About 55 mins to fix
      src/rules/deprecation.ts on lines 317..319

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function createRuleForIdentifier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function createRuleForIdentifier(
        context: TSESLint.RuleContext<'deprecated', Options>,
      ): TSESLint.RuleFunction<TSESTree.JSXIdentifier | TSESTree.Identifier> {
        return function identifierRule(id) {
          const services = ESLintUtils.getParserServices(context);
      Severity: Minor
      Found in src/rules/deprecation.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getDeprecation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function getDeprecation(
        id: TSESTree.Identifier | TSESTree.JSXIdentifier,
        services: RequiredParserServices,
        context: TSESLint.RuleContext<MessageIds, Options>,
      ) {
      Severity: Minor
      Found in src/rules/deprecation.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSymbol has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function getSymbol(
        id: TSESTree.Identifier | TSESTree.JSXIdentifier,
        services: RequiredParserServices,
        tc: ts.TypeChecker,
      ) {
      Severity: Minor
      Found in src/rules/deprecation.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return parent.left === id && !isShortHandProperty(parent.parent);
      Severity: Major
      Found in src/rules/deprecation.ts - About 30 mins to fix

        Function isCallExpression has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function isCallExpression(
          node: TSESTree.Node | undefined,
          callee: TSESTree.Node,
        ): node is TSESTree.CallExpression | TSESTree.TaggedTemplateExpression {
          if (node) {
        Severity: Minor
        Found in src/rules/deprecation.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language