Sign upLogin

h2non/pook

View on GitHub
Star

Showing 31 of 31 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def __init__(self, data):
        BaseMatcher.__init__(self, data)

        if isinstance(data, str):
            self.expectation = json.loads(data)
Severity: Major
Found in src/pook/matchers/json.py and 2 other locations - About 1 hr to fix
src/pook/matchers/json_schema.py on lines 12..16
src/pook/matchers/xml.py on lines 12..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _on_request has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _on_request(
Severity: Major
Found in src/pook/interceptors/urllib3.py - About 1 hr to fix

    Function _on_request has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _on_request(self, _request, conn, method, url, body=None, headers=None, **kw):
    Severity: Major
    Found in src/pook/interceptors/http.py - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      (
    pook.post("httpbin.org/post")
    .json({"foo": "bar"})
    .reply(204)
    .json({"error": "simulated"})
      Severity: Minor
      Found in examples/json_matching.py and 1 other location - About 45 mins to fix
      examples/query_params_matching.py on lines 7..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function __call__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def __call__(self, fn):
        """
        Overload Mock instance as callable object in order to be used
        as decorator definition syntax.
      Severity: Minor
      Found in src/pook/mock.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compare has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def compare(expr, value, regex_expr=False):
    """
    Compares an string or regular expression againast a given value.

    Arguments:
      Severity: Minor
      Found in src/pook/compare.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      (
    pook.get("httpbin.org/get")
    .params({"foo": "bar"})
    .reply(204)
    .json({"error": "simulated"})
      Severity: Minor
      Found in examples/query_params_matching.py and 1 other location - About 45 mins to fix
      examples/json_matching.py on lines 8..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _on_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _on_request(
        self, urlopen, path, pool, method, url, body=None, headers=None, **kw
    ):
        # Remove bypass headers
        real_headers = dict(headers or {})
      Severity: Minor
      Found in src/pook/interceptors/urllib3.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def url(self, url):
        if isregex(url):
            self._url = url
        else:
            if not protoregex.match(url):
      Severity: Minor
      Found in src/pook/request.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handler has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def handler(conn, method, url, body=None, headers=None, **kw):
      Severity: Minor
      Found in src/pook/interceptors/urllib3.py - About 35 mins to fix

        Function handler has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def handler(conn, method, url, body=None, headers=None, **kw):
        Severity: Minor
        Found in src/pook/interceptors/http.py - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language