pook/engine.py

Summary

Maintainability
C
1 day
Test Coverage

File engine.py has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from functools import partial
from inspect import isfunction
from .mock import Mock
from .regex import isregex
from .mock_engine import MockEngine
Severity: Minor
Found in pook/engine.py - About 3 hrs to fix

    Engine has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Engine(object):
        """
        Engine represents the mock interceptor and matcher engine responsible
        of triggering interceptors and match outgoing HTTP traffic.
    
    
    Severity: Minor
    Found in pook/engine.py - About 3 hrs to fix

      Function match has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def match(self, request):
              """
              Matches a given Request instance contract against the registered mocks.
      
              If a mock passes all the matchers, its response will be returned.
      Severity: Minor
      Found in pook/engine.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for mapper in self.mappers:
                  request = mapper(request, self)
                  if not request:
                      raise ValueError('map function must return a request object')
      Severity: Minor
      Found in pook/engine.py and 1 other location - About 35 mins to fix
      pook/mock.py on lines 723..726

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status