Sign upLogin

hackedteam/core-android-audiocapture

View on GitHub
Star

Showing 23 of 23 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

fp.write("NFCSTATUS my_"+fn+"() // FIXME\n"\
"{\n"\
"\torig_"+fn+" = (void*) hook_"+fn+".orig;\n"\
"\tlog(\"%s enter\\n\", __func__)\n"\
"\tlog(\"orig_"+fn+ " = %x\\n\", orig_"+fn+")\n\n"\
Severity: Major
Found in dbi_release/genhijacks.py and 1 other location - About 5 hrs to fix
dbi_release/genhijacks.py on lines 65..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

fp.write("#define HOOK_" + fn + " \\\n"\
"hook(&hook_"+fn+", pid, \"libnfc\", \""+fn+"\", my_"+fn+");\\\n"\
"hook_"+fn+".data = &special_"+fn+";\\\n"\
"memset((char*)&special_"+fn+", 0, sizeof(special_"+fn+"));")
Severity: Major
Found in dbi_release/genhijacks.py and 1 other location - About 5 hrs to fix
dbi_release/genhijacks.py on lines 38..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            for r in tracks[t].audioRaw:
                if audioRawBlockLen != len(r):
                    print '\texpected: {} found: {}\t position {}'.format(audioRawBlockLen, len(r), tracks[t].audioRaw.index(r))
Severity: Major
Found in dbi_release/decoder/decoder.py and 1 other location - About 2 hrs to fix
dbi_release/decoder/old_decoder.py on lines 123..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            for r in tracks[t].audioRaw:
                if audioRawBlockLen != len(r):
                    print '\texpected: {} found: {}\t position {}'.format(audioRawBlockLen, len(r), tracks[t].audioRaw.index(r))
Severity: Major
Found in dbi_release/decoder/old_decoder.py and 1 other location - About 2 hrs to fix
dbi_release/decoder/decoder.py on lines 142..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            header[1] = struct.pack('<I',len(''.join(header)) + len(audioRaw) )
Severity: Major
Found in dbi_release/decoder/decoder.py and 1 other location - About 1 hr to fix
dbi_release/decoder/old_decoder.py on lines 117..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            header[1] = struct.pack('<I',len(''.join(header)) + len(audioRaw) )
Severity: Major
Found in dbi_release/decoder/old_decoder.py and 1 other location - About 1 hr to fix
dbi_release/decoder/decoder.py on lines 136..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if tracks[cblkId].sampleRate != sampleRate:
                print '[D] sampleRate changed {} -> {}'.format( sampleRate, tracks[cblkId].sampleRate )
Severity: Minor
Found in dbi_release/decoder/old_decoder.py and 1 other location - About 50 mins to fix
dbi_release/decoder/old_decoder.py on lines 77..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if tracks[cblkId].streamType != streamType:
                print '[D] streamType changed {} -> {}'.format( streamType, tracks[cblkId].streamType )
Severity: Minor
Found in dbi_release/decoder/old_decoder.py and 1 other location - About 50 mins to fix
dbi_release/decoder/old_decoder.py on lines 80..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if( len(audioRaw) != 8 ):
                tracks[cblkId].audioRaw.append(audioRaw)
            else:
                print '\tShouldn\'t take place'
Severity: Minor
Found in dbi_release/decoder/old_decoder.py and 1 other location - About 45 mins to fix
dbi_release/decoder/decoder.py on lines 97..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                if audioRawBlockLen != len(r):
                    print '\texpected: {} found: {}\t position {}'.format(audioRawBlockLen, len(r), tracks[t].audioRaw.index(r))


            #if tracks[t].trackType == 'r':
Severity: Major
Found in dbi_release/decoder/decoder.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    if audioRawBlockLen != len(r):
                    print '\texpected: {} found: {}\t position {}'.format(audioRawBlockLen, len(r), tracks[t].audioRaw.index(r))
                    
            # wechat
            if typeOfTrack == 'out':
    Severity: Major
    Found in dbi_release/decoder/old_decoder.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if trackId not in tracks.keys():
                    tracks[trackId] = Track(trackId, trackType, sampleRate)
                    print '[*]\t\tCreating trackId {}\t\ttrackType: {}\tsampleRate: {}'.format(trackId, trackType, sampleRate)
                    tracks[trackId].epoch.append(epoch)
      Severity: Major
      Found in dbi_release/decoder/decoder.py - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if( len(audioRaw) != 8 ):
                        tracks[trackId].audioRaw.append(audioRaw)
                    else:
                        print '[W]\t\tshouldn\'t take place'
        Severity: Minor
        Found in dbi_release/decoder/decoder.py and 1 other location - About 45 mins to fix
        dbi_release/decoder/old_decoder.py on lines 71..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                sampleRate = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/old_decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                        blockLen = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                cblkId = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/old_decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                        epoch = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                        sampleRate = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                seconds = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/old_decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 50..50
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

                useconds = struct.unpack('<I', dump[position:position+4])[0]
        Severity: Major
        Found in dbi_release/decoder/old_decoder.py and 9 other locations - About 30 mins to fix
        dbi_release/decoder/decoder.py on lines 77..77
        dbi_release/decoder/decoder.py on lines 80..80
        dbi_release/decoder/decoder.py on lines 83..83
        dbi_release/decoder/decoder.py on lines 86..86
        dbi_release/decoder/old_decoder.py on lines 44..44
        dbi_release/decoder/old_decoder.py on lines 47..47
        dbi_release/decoder/old_decoder.py on lines 53..53
        dbi_release/decoder/old_decoder.py on lines 56..56
        dbi_release/decoder/old_decoder.py on lines 59..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language