Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 20 locations. Consider refactoring.
Open

        public static synchronized BBMKeyListener getInstance() {
            if (instance == null) {
                instance = (BBMKeyListener) RuntimeStore.getRuntimeStore().get(GUID);
                if (instance == null) {
                    final BBMKeyListener singleton = new BBMKeyListener();
Severity: Major
Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java and 19 other locations - About 1 hr to fix
InjectionFramework/src/blackberry/application/AppListener.java on lines 72..82
InjectionFramework/src/blackberry/injection/InjectorManager.java on lines 60..72
InjectionFramework/src/blackberry/interfaces/Singleton.java on lines 18..29
RCSBlackBerry/src/blackberry/AppListener.java on lines 84..95
RCSBlackBerry/src/blackberry/Messages.java on lines 43..54
RCSBlackBerry/src/blackberry/Singleton.java on lines 27..38
RCSBlackBerry/src/blackberry/Status.java on lines 66..77
RCSBlackBerry/src/blackberry/Task.java on lines 51..62
RCSBlackBerry/src/blackberry/debug/DebugWriter.java on lines 66..80
RCSBlackBerry/src/blackberry/fs/Path.java on lines 78..92
RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 76..88
RCSBlackBerry/src/blackberry/location/LocationHelper.java on lines 40..50
RCSBlackBerry/src/blackberry/manager/ActionManager.java on lines 35..46
RCSBlackBerry/src/blackberry/manager/EventManager.java on lines 43..55
RCSBlackBerry/src/blackberry/manager/ModuleManager.java on lines 45..56
RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 76..87
RCSBlackBerry/src/blackberry/module/mms/MmsListener.java on lines 47..59
RCSBlackBerry/src/blackberry/module/sms/SmsListener45.java on lines 51..63
RCSBlackBerry/src/blackberry/module/sms/SmsListener46.java on lines 82..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status