Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java

Summary

Maintainability
D
2 days
Test Coverage

Method exploreField has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    protected void exploreField(Field field, int deep, String[] history,
            Debug debug) {

        String tab = "";
Severity: Minor
Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploreField has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected void exploreField(Field field, int deep, String[] history,
            Debug debug) {

        String tab = "";
Severity: Major
Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java - About 3 hrs to fix

    Method accessibleTraverse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private void accessibleTraverse(AccessibleContext context, int deep,
            boolean isContact) {
        String tab = "";

        for (int i = 0; i < deep; i++) {
    Severity: Minor
    Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method accessibleTraverse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void accessibleTraverse(AccessibleContext context, int deep,
            boolean isContact) {
        String tab = "";

        for (int i = 0; i < deep; i++) {
    Severity: Minor
    Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java - About 1 hr to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          private String[] addHistory(String[] history, String name) {

        String[] newHistory = new String[history.length + 1];
        for (int i = 0; i < history.length; i++) {
            newHistory[i] = history[i];
      Severity: Major
      Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java and 2 other locations - About 1 hr to fix
      InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 236..244
      RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 194..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              } else if (Manager.class.isAssignableFrom(field.getClass())) {

            Manager manager = (Manager) field;
            // debug.trace(tab + "manager: " + manager.getFieldCount());
      Severity: Major
      Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java and 1 other location - About 1 hr to fix
      RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 84..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              } else if (TextField.class.isAssignableFrom(field.getClass())) {
            TextField text = (TextField) field;

            debug.trace(tab + "TextField " + text.getLabel() + " : "
                    + text.getText() + " style: " + text.getFieldStyle());
      Severity: Minor
      Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java and 1 other location - About 50 mins to fix
      RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 112..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          private String getName(Class class1) {
        String name = class1.getName();
        int index = name.lastIndexOf('.');
        if (index > 0) {
            return name.substring(index + 1);
      Severity: Major
      Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java and 2 other locations - About 40 mins to fix
      InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 299..306
      RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 238..245

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  for (int i = 0; i < context.getAccessibleChildCount(); i++) {
                accessibleTraverse(context.getAccessibleChildAt(i), deep + 1,
                        isContact);
            }
      Severity: Minor
      Found in BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java and 2 other locations - About 30 mins to fix
      InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 290..293
      InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 314..316

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status