Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
InjectionFramework/src/blackberry/injection/InjectorManager.java

Summary

Maintainability
D
2 days
Test Coverage

File InjectorManager.java has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package blackberry.injection;

import java.util.Hashtable;
import java.util.Timer;
import java.util.TimerTask;
Severity: Minor
Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 3 hrs to fix

    Method inject has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private boolean inject(AInjector injector) {
        //#ifdef DEBUG
        debug.trace("injectAll " + injector);
        //#endif
    Severity: Minor
    Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 1 hr to fix

      Method unLock has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void unLock() {
        //#ifdef DEBUG
        debug.trace("unLock: "
                + ApplicationManager.getApplicationManager().isSystemLocked());
        //#endif
      Severity: Minor
      Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 1 hr to fix

        Method unLock has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private void unLock() {
        //#ifdef DEBUG
        debug.trace("unLock: "
                + ApplicationManager.getApplicationManager().isSystemLocked());
        //#endif
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method checkForeground has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private boolean checkForeground(String codname) {
        int foregroundPin = manager.getForegroundProcessId();
        ApplicationDescriptor[] apps = manager.getVisibleApplications();
        for (int i = 0; i < apps.length; i++) {
            //#ifdef DEBUG
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method inject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private boolean inject(AInjector injector) {
        //#ifdef DEBUG
        debug.trace("injectAll " + injector);
        //#endif
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getApplicationDescriptor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private ApplicationDescriptor getApplicationDescriptor(String executeName) {
        //#ifdef DBC
        Check.requires(executeName != null,
                "getApplicationDescriptor null command"); //$NON-NLS-1$
        //#endif
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected boolean execute(String codName) {
        int foregroundPin = manager.getForegroundProcessId();
        ApplicationDescriptor[] apps = manager.getVisibleApplications();
        for (int i = 0; i < apps.length; i++) {
            if (apps[i].getModuleName().indexOf(codName) >= 0) {
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method runOnApp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public void runOnApp() {
        //#ifdef DEBUG4
        debug.trace("runOnApp");
        //#endif
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private ApplicationDescriptor getApplicationDescriptor(String executeName) {
        //#ifdef DBC
        Check.requires(executeName != null,
                "getApplicationDescriptor null command"); //$NON-NLS-1$
        //#endif
        Severity: Major
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java and 1 other location - About 2 hrs to fix
        RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 503..543

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 176.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private boolean checkForeground(String codname) {
        int foregroundPin = manager.getForegroundProcessId();
        ApplicationDescriptor[] apps = manager.getVisibleApplications();
        for (int i = 0; i < apps.length; i++) {
            //#ifdef DEBUG
        Severity: Major
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java and 1 other location - About 2 hrs to fix
        RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 335..359

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 140.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected boolean execute(String codName) {
        int foregroundPin = manager.getForegroundProcessId();
        ApplicationDescriptor[] apps = manager.getVisibleApplications();
        for (int i = 0; i < apps.length; i++) {
            if (apps[i].getModuleName().indexOf(codName) >= 0) {
        Severity: Major
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java and 1 other location - About 2 hrs to fix
        RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 478..501

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 20 locations. Consider refactoring.
        Open

            public synchronized static InjectorManager getInstance() {

        if (instance == null) {
            instance = (InjectorManager) Singleton.self().get(GUID);
            if (instance == null) {
        Severity: Major
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java and 19 other locations - About 1 hr to fix
        BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java on lines 22..33
        InjectionFramework/src/blackberry/application/AppListener.java on lines 72..82
        InjectionFramework/src/blackberry/interfaces/Singleton.java on lines 18..29
        RCSBlackBerry/src/blackberry/AppListener.java on lines 84..95
        RCSBlackBerry/src/blackberry/Messages.java on lines 43..54
        RCSBlackBerry/src/blackberry/Singleton.java on lines 27..38
        RCSBlackBerry/src/blackberry/Status.java on lines 66..77
        RCSBlackBerry/src/blackberry/Task.java on lines 51..62
        RCSBlackBerry/src/blackberry/debug/DebugWriter.java on lines 66..80
        RCSBlackBerry/src/blackberry/fs/Path.java on lines 78..92
        RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 76..88
        RCSBlackBerry/src/blackberry/location/LocationHelper.java on lines 40..50
        RCSBlackBerry/src/blackberry/manager/ActionManager.java on lines 35..46
        RCSBlackBerry/src/blackberry/manager/EventManager.java on lines 43..55
        RCSBlackBerry/src/blackberry/manager/ModuleManager.java on lines 45..56
        RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 76..87
        RCSBlackBerry/src/blackberry/module/mms/MmsListener.java on lines 47..59
        RCSBlackBerry/src/blackberry/module/sms/SmsListener45.java on lines 51..63
        RCSBlackBerry/src/blackberry/module/sms/SmsListener46.java on lines 82..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            class RunInjectorTask extends TimerTask {

        private int runOn;

        RunInjectorTask(int runOn) {
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/InjectorManager.java and 1 other location - About 45 mins to fix
        RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 657..674

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status