Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
InjectionFramework/src/blackberry/injection/MenuWalker.java

Summary

Maintainability
D
2 days
Test Coverage

Method walk has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public static boolean walk(String[] menus, Screen screen, boolean simple) {
        //#ifdef DEBUGWALK
        final Debug debug = new Debug("walk", DebugLevel.VERBOSE);
        debug.trace("walk, active screen:" + UiApplication.getUiApplication().getActiveScreen() + " Screen: " + screen);
Severity: Minor
Found in InjectionFramework/src/blackberry/injection/MenuWalker.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method walk has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static boolean walk(String menuItemText, Screen screen, boolean simple) {
        final Debug debug = new Debug("walk", DebugLevel.INFORMATION);

        debug.trace("walk: " + menuItemText + " screen: " + screen);
        boolean ret = false;
Severity: Minor
Found in InjectionFramework/src/blackberry/injection/MenuWalker.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method walk has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static boolean walk(String[] menus, Screen screen, boolean simple) {
        //#ifdef DEBUGWALK
        final Debug debug = new Debug("walk", DebugLevel.VERBOSE);
        debug.trace("walk, active screen:" + UiApplication.getUiApplication().getActiveScreen() + " Screen: " + screen);
Severity: Major
Found in InjectionFramework/src/blackberry/injection/MenuWalker.java - About 2 hrs to fix

    Method walk has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static boolean walk(String menuItemText, Screen screen, boolean simple) {
        final Debug debug = new Debug("walk", DebugLevel.INFORMATION);

        debug.trace("walk: " + menuItemText + " screen: " + screen);
        boolean ret = false;
    Severity: Minor
    Found in InjectionFramework/src/blackberry/injection/MenuWalker.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public static boolean walk(String[] menus, Screen screen, boolean simple) {
        //#ifdef DEBUGWALK
        final Debug debug = new Debug("walk", DebugLevel.VERBOSE);
        debug.trace("walk, active screen:" + UiApplication.getUiApplication().getActiveScreen() + " Screen: " + screen);
      Severity: Major
      Found in InjectionFramework/src/blackberry/injection/MenuWalker.java and 1 other location - About 6 hrs to fix
      RCSBlackBerry/src/blackberry/injection/MenuWalker.java on lines 56..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 413.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public static boolean walk(String menuItemText, Screen screen, boolean simple) {
        final Debug debug = new Debug("walk", DebugLevel.INFORMATION);

        debug.trace("walk: " + menuItemText + " screen: " + screen);
        boolean ret = false;
      Severity: Major
      Found in InjectionFramework/src/blackberry/injection/MenuWalker.java and 1 other location - About 5 hrs to fix
      BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/MenuWalker.java on lines 32..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 321.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status